Repository navigation
Conversation
strptime %Y matches exactly four digits, so interpolating an unpadded year made 0416-W34-6 and similar week dates raise ParserError. Fixes python-pendulum#1076
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Fixes #1076
_get_iso_8601_weekbuilt astrptimestring asf"{year}-{ordinal}".%Yneeds exactly four digits, so week dates with a year below 1000 (0416-W34-6,0999-W34-6,0004-W10-5, basic0416W346) raisedParserErroreven though the same years parse as calendar dates.Zero-pad the year. Existing week dates (
2012-W05,2009-W53-7, …) are unchanged.