Skip to content

A few more more Tox cleanup bits #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wsanchez merged 1 commit into from
Apr 6, 2020
Merged

A few more more Tox cleanup bits #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/docs/_build
/docs/_build/
tmp.py
*.py[cod]

Expand Down Expand Up @@ -37,7 +37,10 @@ nosetests.xml
/.coverage
/.coverage.*
/htmlcov/
/.mypy_cache
/.mypy_cache/

# Documentation
/htmldocs/

# Translations
*.mo
Expand Down
12 changes: 6 additions & 6 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

envlist =
flake8, mypy
test-py{26,27,34,35,36,37,38,py,py3}
test-py{26,27,34,35,36,37,38,py2,py3}
coverage_report
packaging
docs
packaging

skip_missing_interpreters = {tty:True:False}

Expand Down Expand Up @@ -182,12 +182,12 @@ description = generate coverage report

depends = test-py{26,27,34,35,36,37,38,py,py3}

basepython = python
basepython = {[default]basepython}

skip_install = True

deps =
coverage==4.5.4 # rq.filter: <5
coverage==4.5.4 # rq.filter: <5 # coverage 5.0 drops Python 3.4 support

setenv =
{[default]setenv}
Expand Down Expand Up @@ -265,7 +265,7 @@ commands =
sphinx-build \
-b html -d "{envtmpdir}/doctrees" \
"{toxinidir}/docs" \
"{toxworkdir}/docs/html"

@wsanchez wsanchez Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to match other projects, and similar to /htmlcov/.

@mahmoud mahmoud Apr 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, other hyper projects, or which other projects?

@wsanchez wsanchez Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Klein in particular; I'm trying to keep the configs relatively similar for sanity.

@glyph glyph Apr 6, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me whispers "we need a tool to keep them in sync"

@wsanchez wsanchez Apr 6, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I KNOW

"{toxworkdir}/htmldocs"


[testenv:docs-auto]
Expand All @@ -283,7 +283,7 @@ commands =
-b html -d "{envtmpdir}/doctrees" \
--host=localhost \
"{toxinidir}/docs" \
"{toxworkdir}/docs/html"
"{toxworkdir}/htmldocs"


##
Expand Down