Skip to content

Emit priority data - #233

Merged
Lukasa merged 9 commits into
masterfrom
emit-priority-data
May 29, 2016
Merged

Lukasa merged 9 commits into
masterfrom
emit-priority-data

Conversation

@Lukasa

@Lukasa Lukasa commented May 28, 2016

Copy link
Copy Markdown
Member

Resolves #229.

/cc @Kriechi

I'm a bit nervous about the fact that the kwargs are different in send_headers and prioritize, but otherwise I think this is ok.

@Lukasa
Lukasa force-pushed the emit-priority-data branch from 18baca0 to bfbed52 Compare May 28, 2016 18:13
@Kriechi

Kriechi commented May 28, 2016

Copy link
Copy Markdown
Member

LGTM! Thanks for the fast response and implementation! 🎉

Should we also add Priority information upon receiving (i.e. generating a RequestReceived)?
https://github.com/python-hyper/hyper-h2/blob/3e3ce61824e4f5d9bc4732aae72cf44b15f3fbc8/h2/stream.py#L160

@Lukasa

Lukasa commented May 28, 2016

Copy link
Copy Markdown
Member Author

Yeah, probably. =D Let's use a new ticket.

@Lukasa
Lukasa merged commit 123dacc into master May 29, 2016
@Lukasa
Lukasa deleted the emit-priority-data branch May 29, 2016 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants