Skip to content

Improve handling of diverse coordinate datatypes #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukelbd merged 4 commits into from
Feb 10, 2020
Merged

Improve handling of diverse coordinate datatypes #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75747f1
Support cftime, only apply IndexFormatter to string arrays
lukelbd Feb 10, 2020
c00b7ab
Ensure numeric arrays for center-to-edges conversion and vice-versa
lukelbd Feb 10, 2020
3ea6ee4
Black-like formatting
lukelbd Feb 10, 2020
27634b2
Update changelog
lukelbd Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ ProPlot v0.5.0 (2020-##-##)
were sometimes ignored (:commit:`fd4f8d5f`).
- Prevent formatting rightmost meridian label as ``1e-10``
on cartopy map projections (:commit:`37fdd1eb]`).
- Support CF-time axes by fixing bug in `~proplot.wrappers.standardize_1d`
and `~proplot.wrappers.standardize_2d` (:issue:`103`, :pr:`121`).
- Redirect to the "default" location
when using ``legend=True`` and ``colorbar=True`` to generate on-the-fly legends
and colorbars (:commit:`c2c5c58d`). This feature was accidentally removed.
Expand Down
9 changes: 6 additions & 3 deletions proplot/axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,8 +1890,10 @@ def _datex_rotate(self):
# NOTE: Rotation is done *before* horizontal/vertical alignment,
# cannot change alignment with set_tick_params. Must apply to text
# objects. fig.autofmt_date calls subplots_adjust, so cannot use it.
if (not isinstance(self.xaxis.converter, mdates.DateConverter)
or self._datex_rotated):
if (
not isinstance(self.xaxis.converter, mdates.DateConverter)
or self._datex_rotated
):
return
rotation = rc['axes.formatter.timerotation']
kw = {'rotation': rotation}
Expand Down Expand Up @@ -2649,7 +2651,8 @@ def _grid_dict(grid):
locator = axis.get_major_locator()
formatter_kw.setdefault('locator', locator)
formatter = axistools.Formatter(
formatter, date=date, **formatter_kw)
formatter, date=date, **formatter_kw
)
axis.set_major_formatter(formatter)

# Ensure no out-of-bounds ticks; set_smart_bounds() can fail
Expand Down
Loading