Repository navigation
Collect the ternary-contour pole-labels test - #5866
Open
dylanpulver wants to merge 1 commit into
Open
dylanpulver wants to merge 1 commit into
dylanpulver wants to merge 1 commit into
Conversation
TestTernarycontour.check_pole_labels sits among the test_ methods, takes no arguments beyond self and nothing calls it, so it has never been collected. Unlike compare_list_values and compare_dict_values alongside it, which are real helpers called by other tests, this one builds a figure and asserts. Renaming it to test_pole_labels runs it and it passes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestTernarycontour.check_pole_labelssits among thetest_methods, takes no arguments beyondself, and nothing calls it, so it has never been collected. The two similarly-named methods alongside it,compare_list_valuesandcompare_dict_values, are real helpers that take arguments and are called by other tests; this one builds a figure and asserts.Renaming it to
test_pole_labelsruns it and it passes, taking the class from 4 collected tests to 5.It covers behaviour nothing else does. Changing
_ternary_contour.py:39so theaaxistitle readspole_labels[1]instead ofpole_labels[0]:mainthe class still reports 4 passedRun with
.[dev_optional]installed.