Skip to content

Use runtime.CallersFrames for StackTrace - #108

Closed
alfred-landrum wants to merge 1 commit into
pkg:masterfrom
alfred-landrum:runtime-callersframes
Closed

alfred-landrum wants to merge 1 commit into
pkg:masterfrom
alfred-landrum:runtime-callersframes

Conversation

@alfred-landrum

@alfred-landrum alfred-landrum commented Mar 8, 2017 •

Copy link
Copy Markdown

Given the deprecation warning about runtime.FuncForPC in:
https://docs.google.com/presentation/d/1Wcblp3jpfeKwA0Y4FOmj63PW52M_qmNqlQkNaLj0P5o/edit?usp=sharing

I'd thought I'd see what a shift to use runtime.CallersFrames would look like. I'm not yet sure of the tradeoffs for one or the other, but thought I'd share code that passes existing tests locally in case its of interest.

@davecheney

davecheney commented Mar 8, 2017 •

Copy link
Copy Markdown
Member

Please open an issue to track this before slinging code, thank you.

https://github.com/pkg/errors#contributing

@alfred-landrum

Copy link
Copy Markdown
Author

will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants