Repository navigation
migrate doc redirects to redirects.json sidecar from doc-en - #1960
jordikroon wants to merge 1 commit into
Conversation
|
Do other languages also need to generate a redirects.xml file? |
|
No. While technically they can, we should only load doc-en. The file is explicitly marked as Though it will be very likely that we will add a variant of redirects.xml to doc-ext (third-party extension manual) in the future. Having the redirects.xml in doc-en (not doc-base) allows us to manage redirects from one PR, rather than having PRs to depend on each other. It also allows a variant in doc-ext in later on. |
| // 'both' - matches at either entry point | ||
|
|
||
| $docRedirects = is_file(__DIR__ . '/manual/en/redirects.json') | ||
| ? json_decode(file_get_contents(__DIR__ . '/manual/en/redirects.json'), true) |
There was a problem hiding this comment.
json_decode() can also fail of the JSON file is corrupted for some reason. Please guard against that.
|
#2038 includes this commit and falls back to empty maps when the JSON can't be decoded. Would it be easier to review it there and close this one? |
The goal for this PR is to migrate all doc related redirects out of web-php.
Instead we generate a
redirects.jsonfromredirects.xmlwhich is then loaded in-place.Redirects not related to docs are NOT migrated. However shortcuts are.
Depends on:
php/phd#260
php/doc-en#5658