You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
README.md examples out of date with the source? #96
It would be great if someone could go through all of the commands that README.md invites you to run with this repository, as many of them seem to no longer make sense for this structure.
e.g.
./pants test helloworld/util/lang_test.py
there is no longer a util folder under helloworld
Also, from a monorepo perspective.. should there be another directory along side helloworld representing another application that takes a dependency upon the helloworld library (maybe a helloworldcli that is the 'app' and hello world is the library, potentially shared with other executable apps, helloworldservice etc etc)
Thanks for the report. An oversight from #85 to not update the readme.
Also, from a monorepo perspective.. should there be another directory along side helloworld
That will work. However, I think for a more involved setup, that you'd have a common "source root" to not "pollute" the top level tree, so have src/helloworld or even src/python/helloworld or whatever structure would make sense for the project.
This example repo is very minimalistic to show the bare minimums to get started without a lot of complexity.
Thanks for the heads up! Sorry the readme got stale, will fix asap.
As @kaos mentioned, while Pants can support multiple "source roots" (https://www.pantsbuild.org/docs/source-roots) we tend to prefer having multiple projects nested under a single one, and this setup is kind of a gentle nudge in that direction.
Activity
kaos commentedon Mar 22, 2022
Thanks for the report. An oversight from #85 to not update the readme.
That will work. However, I think for a more involved setup, that you'd have a common "source root" to not "pollute" the top level tree, so have
src/helloworldor evensrc/python/helloworldor whatever structure would make sense for the project.This example repo is very minimalistic to show the bare minimums to get started without a lot of complexity.
benjyw commentedon Mar 22, 2022
Thanks for the heads up! Sorry the readme got stale, will fix asap.
As @kaos mentioned, while Pants can support multiple "source roots" (https://www.pantsbuild.org/docs/source-roots) we tend to prefer having multiple projects nested under a single one, and this setup is kind of a gentle nudge in that direction.
benjyw commentedon Mar 22, 2022
Fixed, thanks for the report @jimmcslim