Repository navigation
Configurable domain checker additional providers - #1
Merged
optimode merged 2 commits intoJun 5, 2026
Merged
Conversation
Owner
|
Hi @moraleja39 — thanks a lot for this! Squashed and merged into This is the first external contribution emailkit has received, so it means a lot that it was such a thoughtful one. The feature fits cleanly, it's backward compatible, and it's great that you covered both the new option and the existing behaviour with tests. I'll add a note to the README and CHANGELOG for the new option shortly. If you ever spot other gaps or have ideas, issues and PRs are very welcome. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was missing this option to add some local providers. I have also added some test to the domain checker, for the existing and added functionality.