Repository navigation
OCPBUGS-137031: Remove extra newline from featuregated CRD manifest reports - #3183
Conversation
…eports The empty-partial-schemas generator writes each CRD entry of the zz_generated.featuregated-crd-manifests.yaml reports with fmt.Fprintf(w, "%v\n", content). yaml.Marshal output already ends with a newline, so every entry was followed by a blank line, including the last one. As a result every report ended with a blank line at EOF, which whitespace checks such as git diff --check flag in consumers that vendor these files. Write the marshaled entry bytes as they are, through a small writeCRDInfoEntry helper, and add unit tests for the empty, single and multiple entry cases and for writer error propagation. Regenerate with make update. The 35 report files only lose their blank lines; their YAML content and entry order are unchanged, and no CRD manifest, schema or feature gate output changes.
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-137031, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @redhat-chai-bot! Some important instructions when contributing to openshift/api: |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@redhat-chai-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Write marshaled feature-gated CRD report entries directly instead of appending a second newline. The YAML marshaler already terminates each entry with a newline.
Validation
make update, including protobuf regeneration with protoc 23.4, reproduces the committed tree without changes.git diff --checkpasses and the working tree is clean.Actual Prow jobs and CI image builds have not run yet; they require this PR.
AI-generated. Review for accuracy.
@rikatz requested from Slack
Chai persona:
NID Agentic SDLC