Skip to content

CNTRLPLANE-4405: Graduate ExternalOIDCAsWebhook to GA - #3151

Open
gangwgr wants to merge 1 commit into
openshift:masterfrom
gangwgr:external-oidc-as-webhook-ga
Open

gangwgr wants to merge 1 commit into
openshift:masterfrom
gangwgr:external-oidc-as-webhook-ga

Conversation

@gangwgr

@gangwgr gangwgr commented Nov 3, 2026 •

Copy link
Copy Markdown

CNTRLPLANE-4405: Graduate ExternalOIDCAsWebhook to GA

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Nov 3, 2026 •

Copy link
Copy Markdown

@gangwgr: This pull request references CNTRLPLANE-4405 which is a valid jira issue.

Details

In response to this:

CNTRLPLANE-4405: Graduate ExternalOIDCAsWebhook to GA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Hello @gangwgr! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

ExternalOIDCAsWebhook is enabled in the Default and OKD feature sets and in six payload manifests. The feature table now lists it as enabled across the specified deployment types and release channels.

Suggested reviewers: bertinatto, dfajmon, abhay-nutanix

Merge Risk: Minimal · up to f80aa

The GA enablement scope is consistent across configuration and documentation, with no actionable merge risk identified.

Pre-merge checks: Passed 15
Check name Status Explanation
Title check Passed The title clearly identifies the main change: graduating ExternalOIDCAsWebhook to GA.
Description check Passed The description directly states that ExternalOIDCAsWebhook is being graduated to GA and matches the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names Passed PASS: The pull request changes only feature-gate documentation, Go feature-gate registration, and YAML manifests. It adds no Ginkgo tests or test titles, so it introduces no unstable or overly-specifi…
Test Structure And Quality Passed The pull request changes only feature documentation, feature-gate registration, and YAML manifests. No test source files or new Ginkgo It blocks were added, so the listed test-structure requirements d…
Microshift Test Compatibility Passed PASS: The pull request changes only feature documentation, feature-gate registration, and generated feature-gate manifests. The authoritative diff adds no Ginkgo tests or other test code, so the Micro…
Single Node Openshift (Sno) Test Compatibility Passed The pull request changes only feature-gate metadata and YAML manifests. It adds no Ginkgo e2e tests or other test code, so the SNO multi-node compatibility check is not applicable.
Topology-Aware Scheduling Compatibility Passed PASS: The PR only changes feature-gate registration, documentation, and feature-gate payload entries. The diff adds no deployments, controllers, operators, replicas, affinity, topology spread, node se…
Ote Binary Stdout Contract Passed PASS. The pull request changes feature-gate registration, Markdown, and YAML manifests only. The Go diff adds feature sets to FeatureGateExternalOIDCAsWebhook; it adds no process-level stdout writes…
Ipv6 And Disconnected Network Test Compatibility Passed The pull request changes feature documentation, feature-gate registration, and YAML manifests only. It adds no Ginkgo e2e tests and no IPv4 or external-connectivity test code.
No-Weak-Crypto Passed PASS. The pull request changes only feature-gate documentation, Go registration, and YAML manifests. The code change adds ExternalOIDCAsWebhook to enabled feature sets. The changed lines introduce n…
Container-Privileges Passed The pull request changes feature-gate documentation, Go feature registration, and feature-gate lists only. The diff adds or moves ExternalOIDCAsWebhook. It introduces no container or workload specif…
No-Sensitive-Data-In-Logs Passed PASS. The pull request only changes feature-gate declarations, documentation, and manifest membership for ExternalOIDCAsWebhook. It adds no logging code or sensitive data, and the added lines contai…
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (7 skipped: 7 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only feature-gate documentation, Go feature-gate registration, and YAML manifests. It adds no Ginkgo tests or test titles, so it introduces no unstable or overly-specific test names.

Full details: Test Structure And Quality

Explanation

The pull request changes only feature documentation, feature-gate registration, and YAML manifests. No test source files or new Ginkgo It blocks were added, so the listed test-structure requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only feature documentation, feature-gate registration, and generated feature-gate manifests. The authoritative diff adds no Ginkgo tests or other test code, so the MicroShift test compatibility check does not apply.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The PR only changes feature-gate registration, documentation, and feature-gate payload entries. The diff adds no deployments, controllers, operators, replicas, affinity, topology spread, node selectors, tolerations, PDBs, or other scheduling constraints. Therefore it does not introduce a topology compatibility issue.

Full details: Ote Binary Stdout Contract

Explanation

PASS. The pull request changes feature-gate registration, Markdown, and YAML manifests only. The Go diff adds feature sets to FeatureGateExternalOIDCAsWebhook; it adds no process-level stdout writes, logging configuration, or OTE suite setup.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only feature-gate documentation, Go registration, and YAML manifests. The code change adds ExternalOIDCAsWebhook to enabled feature sets. The changed lines introduce no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret/token comparisons.

Full details: Container-Privileges

Explanation

The pull request changes feature-gate documentation, Go feature registration, and feature-gate lists only. The diff adds or moves ExternalOIDCAsWebhook. It introduces no container or workload specifications and no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS. The pull request only changes feature-gate declarations, documentation, and manifest membership for ExternalOIDCAsWebhook. It adds no logging code or sensitive data, and the added lines contain no passwords, tokens, API keys, PII, hostnames, session IDs, or customer data.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

golangci-lint (2.14.0)

golangci-lint (2.14.0) skipped for .golangci.yaml: configuration contains disallowed or uninspectable plugin or linter settings. Use supported built-in linters.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: openshift/api
  • Branch: master
  • File: .coderabbit.yaml
  • Commit: 9a8f95c
  • Layers: Repository YAML (base), Central YAML (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 8e1d6ce4-c84b-4011-851f-eac423052ac6
Commits

Reviewing files that changed from the base of the PR and between 9a8f95c and f80aaf9.

Files selected for processing: 8
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-SelfManagedHA-OKD.yaml
  • payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-OKD.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2026
@openshift-ci

openshift-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@gangwgr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion f80aaf9 link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven

everettraven commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Looks like we currently only have this feature gate marked as owning the jobs:

  • periodic-ci-openshift-cluster-authentication-operator-release-5.1-periodics-e2e-aws-external-oidc-configure-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-5.1-periodics-e2e-aws-external-oidc-revertoauth-techpreview
  • periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-external-oidc-techpreview
  • periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-azure-aks-external-oidc-techpreview

The hypershift ones seem fine to me and I would consider that sufficient hypershift testing.

For standalone, I would have expected jobs:

  • On all supported platforms, we are missing GCP, Azure, Metal and VSphere for the *-configure-techpreview and *-revertoauth-techpreview jobs.
  • I'd like to also see jobs running the rest of the test cases we have for external oidc. I was expecting to see jobs with suffixes like:
    • *-uid-extra-techpreview
    • *-upstream-parity-techpreview

Additionally, looking at https://sippy.dptools.openshift.org/sippy-ng/feature_gates/5.1/ExternalOIDCAsWebhook - it looks like we need to collect more test runs and ensure the existing regressions that were found go away.

@gangwgr

gangwgr commented Nov 5, 2026

Copy link
Copy Markdown
Author

/hold
wait for all pr merged for featuregate

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants