Repository navigation
Conversation
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
|
@gangwgr: This pull request references CNTRLPLANE-4405 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @gangwgr! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@gangwgr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Looks like we currently only have this feature gate marked as owning the jobs:
The hypershift ones seem fine to me and I would consider that sufficient hypershift testing. For standalone, I would have expected jobs:
Additionally, looking at https://sippy.dptools.openshift.org/sippy-ng/feature_gates/5.1/ExternalOIDCAsWebhook - it looks like we need to collect more test runs and ensure the existing regressions that were found go away. |
|
/hold |
CNTRLPLANE-4405: Graduate ExternalOIDCAsWebhook to GA