Repository navigation
Conversation
There was no way to stop a scan from the CLI. Pairs with the new
POST /api/projects/{id}/scans/{scan_id}/cancel route (openhackai/app#53),
which cancels the Temporal workflow and marks the scan cancelled.
openhack-cli scans cancel <scan_id> [--project ID] [--yes]
Confirms before cancelling on an interactive run, and skips the prompt
under --json so scripted use can't hang on a hidden prompt.
Reports which thing actually happened. The route returns
workflow_cancelled: false when the workflow was already gone (the worker
died, or the scan finished between the read and the call) — the scan is
still marked cancelled, so saying "cancelled" flatly would imply we
stopped something that was no longer running.
Also recolours the "cancelled" status from red to dim. A deliberate
cancel is not a failure, and the dashboard renders it muted; matching red
to "failed" made an intentional action look like an error.
https://claude.ai/code/session_011bV5NF1FAx8trn8MxHjAVM
[Medium impact] The PR appears safe to merge, with the documented requirement that the server cancellation route be deployed before use. SummaryAdds
Reviews (1) · Last reviewed commit: "docs: document scan cancellation" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.