Skip to content

Update contributor-list/package-lock.json. - #1639

Merged
lpinca merged 1 commit into
nodejs:masterfrom
Trott:oplj
May 1, 2018
Merged

lpinca merged 1 commit into
nodejs:masterfrom
Trott:oplj

Conversation

@Trott

@Trott Trott commented Apr 29, 2018

Copy link
Copy Markdown
Member

This updates hoek@2 to hoek@4.2.1.

I wasn't able to test the relevant script because it didn't work for me even with no changes. So, maybe someone else can confirm that it's still in use and that it works? (Maybe GitHub was having issues when I tried? I'm pretty sure my API token would have the needed permissions.)

This updates hoek@2 to hoek@4.2.1.
@WaleedAshraf

Copy link
Copy Markdown
Contributor

@WaleedAshraf WaleedAshraf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran the script without any error with these steps.

  • Pulled latest
  • npm install
  • GITHUB_API_TOKEN=<your token> node index.js <since date: YYYY-MM-DD>

@Trott

Trott commented Apr 29, 2018

Copy link
Copy Markdown
Member Author

@WaleedAshraf It's in package-lock.json, not package.json, because it's a dependency of a dependency.

@Trott

Trott commented Apr 29, 2018

Copy link
Copy Markdown
Member Author

I just ran the script without any error with these steps.

👍 Thanks!

@Trott

Trott commented Apr 29, 2018

Copy link
Copy Markdown
Member Author

(For what it's worth, those are the steps I took and it seemed to take a looooong time. Maybe I just wasn't patient enough? I think I waited a minute or two.)

@WaleedAshraf

WaleedAshraf commented Apr 29, 2018 •

Copy link
Copy Markdown
Contributor

Maybe something with the date. What date you used?
For me with 2018-01-01, it took few seconds.

@fhemberger

Copy link
Copy Markdown
Contributor

@Trott Yes, it's still in use and it should work. ;)

@Trott

Trott commented Apr 30, 2018

Copy link
Copy Markdown
Member Author

I'm going to guess it's my API token/account permissions. Regardless, as long as it is working, great.

@fhemberger

Copy link
Copy Markdown
Contributor

@Trott Why are there two PRs for this change? 🤔

@WaleedAshraf

Copy link
Copy Markdown
Contributor

@fhemberger One is for nodejs.org/package-lock.json and other for nodejs.org/scripts/contributor-list/package-lock.json

I think both can be closed?

@Trott

Trott commented Apr 30, 2018

Copy link
Copy Markdown
Member Author

I think both can be closed?

No, they should not be closed. hoek should be updated.

@WaleedAshraf WaleedAshraf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca
lpinca merged commit 22c4f69 into nodejs:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants