Repository navigation
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Member
Author
|
Confirmed that https://ci.nodejs.org/job/node-stress-single-test/979/ has demonstrated 1000/1000 passes of the test with this PR on both test-osuosl-rhel10-ppc64_le-1 and test-osuosl-rhel8-ppc64_le-4. |
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67379 +/- ##
==========================================
- Coverage 92.62% 90.72% -1.90%
==========================================
Files 430 798 +368
Lines 196333 280074 +83741
Branches 29897 53880 +23983
==========================================
+ Hits 181849 254099 +72250
- Misses 14159 16276 +2117
- Partials 325 9699 +9374 🚀 New features to boost your workflow:
|
Collaborator
Member
Author
|
Noting that this is not exclusive to plinux - it has also been seen as a failure on zlinux: https://ci.nodejs.org/job/node-test-commit-linuxone/59810/nodes=rhel8-s390x/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67374
Some analysis from IBM Bob indicated that the preload streams into startup snapshot PR could have changed the memory allocation in a way that no longer triggers GC events when the test expects them too on Linux/ppc64le. Some tests done locally on one of the machines show that increasing the number of iterations is sufficient for the test to pass consistently as expected after the change on one of the RHEL10 machines, but I will also verify it with a stress test run on the machine that has most frequently seen the error.
Adding Matteo as a review as the author of the preload streams PR and James as original author of the test.
Alternative solution: Make this value specific to Linux/ppc64le since it does not appear to affect other platforms, but the contents of this PR is a simpler change.
We could consider fast tracking this as it has been impacting PR testing and is not a change that affects runtime functionality.