Repository navigation
Conversation
Document formatter setup and usage separately from make lint so contributors can catch C/C++ formatting issues before CI runs. Refs: nodejs#66834 (comment) Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Collaborator
|
Review requested:
|
lpinca
approved these changes
Nov 2, 2026
RaisinTen
approved these changes
Nov 3, 2026
inoway46
added
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request guide recommends
make lint, which does not include the C/C++ formatting check run by CI. Document how to install and run the formatter and remind contributors to commit any formatting changes.This is especially helpful for first-time contributors, whose CI runs may require approval. Running the formatter locally lets them catch formatting issues before waiting for CI.
Refs: #66834 (comment)