Repository navigation
sea: add test and update docs for import() with code cache - #62678
Merged
nodejs-github-bot merged 2 commits intoSep 27, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62678 +/- ##
==========================================
+ Coverage 89.81% 92.48% +2.66%
==========================================
Files 699 809 +110
Lines 216235 299477 +83242
Branches 41336 80051 +38715
==========================================
+ Hits 194216 276977 +82761
+ Misses 14129 12978 -1151
- Partials 7890 9522 +1632
🚀 New features to boost your workflow:
|
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
thisalihassan
force-pushed
the
sea/import-with-code-cache
branch
from
April 10, 2026 20:26
c3bb922 to
ead9914
Compare
joyeecheung
approved these changes
Apr 13, 2026
…amic-import.js Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
aymen94
approved these changes
Apr 14, 2026
joyeecheung
approved these changes
Apr 29, 2026
joyeecheung
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Contributor
|
This pull request has been marked as stale due to 90 days of inactivity. |
github-actions
Bot
added
the
stale
Contributor
|
This pull request has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days). |
Contributor
|
Reopening since this still seems relevant on current main. |
inoway46
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
inoway46
added
commit-queue-squash
inoway46
approved these changes
Sep 27, 2026
Collaborator
|
Landed in 7d79ed3 |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 27, 2026
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com> PR-URL: #62678 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
HoonDongKang
pushed a commit
to HoonDongKang/node
that referenced
this pull request
Sep 28, 2026
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com> PR-URL: nodejs#62678 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 28, 2026
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com> PR-URL: #62678 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
chenxin-yan
added a commit
to chenxin-yan/crust
that referenced
this pull request
Nov 4, 2026
Node.js binaries compiled their whole bundle on every start. tsdown passes seaConfig through to `node --build-sea`, so the build now sets useCodeCache, which makes the SEA load the main module from a V8 code cache instead: a 30-command CLI runs ~15 M fewer instructions per start (~5.5%, 1 to 2 ms), for ~60 KB. The cache is written by the Node running --build-sea (the node on PATH) and V8 rejects it, printing "Code cache data rejected." on every start, unless the embedded binary is that exact build with the same V8 flags. Matching platform and version is not enough: a Nix build of Node 26.10 produced a cache the official 26.10 binary rejected, although both report the same v8.cachedDataVersionTag(). So the build enables it only when the node on PATH is byte-identical to the official binary tsdown embeds for the target (which implies the host target) and NODE_OPTIONS is unset (--jitless there also gets the cache rejected); every other build stays as before. import() of built-ins works with the cache for ESM main scripts, which is what Crust builds (Node 26 docs dropped the old import() caveat in nodejs/node#62678); the integration fixture now exercises it.
chenxin-yan
added a commit
to chenxin-yan/crust
that referenced
this pull request
Nov 4, 2026
Node.js binaries compiled their whole bundle on every start. tsdown passes seaConfig through to `node --build-sea`, so the build now sets useCodeCache, which makes the SEA load the main module from a V8 code cache instead: a 30-command CLI runs ~15 M fewer instructions per start (~5.5%, 1 to 2 ms), for ~60 KB. The cache is written by the Node running --build-sea (the node on PATH) and V8 rejects it, printing "Code cache data rejected." on every start, unless the embedded binary is that exact build with the same V8 flags. Matching platform and version is not enough: a Nix build of Node 26.10 produced a cache the official 26.10 binary rejected, although both report the same v8.cachedDataVersionTag(). So the build enables it only when the node on PATH is byte-identical to the official binary tsdown embeds for the target (which implies the host target) and NODE_OPTIONS is unset (--jitless there also gets the cache rejected); every other build stays as before. import() of built-ins works with the cache for ESM main scripts, which is what Crust builds (Node 26 docs dropped the old import() caveat in nodejs/node#62678); the integration fixture now exercises it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**Note:** import() does not work when useCodeCache is true.restriction from the API documentation.Assisted by: Claude Opus 4.6