Repository navigation
Conversation
Use `LLHTTP_STRICT_MODE` C define to switch between modes instead of separate compilation targets. Remove `bitcode` output as it is slower than C version anyway. See: envoyproxy/envoy#5155 (comment)
Member
Author
|
cc @nodejs/http |
derekargueta
reviewed
May 4, 2020
Member
Author
|
Looks like this fell through the cracks. Anyone care to give this a review @nodejs/http ? |
indutny
force-pushed
the
feature/mode-define
branch
from
July 8, 2020 17:07
8e36804 to
3186a42
Compare
indutny
added a commit
that referenced
this pull request
Jul 13, 2020
Use `LLHTTP_STRICT_MODE` C define to switch between modes instead of separate compilation targets. Remove `bitcode` output as it is slower than C version anyway. See: envoyproxy/envoy#5155 (comment) PR-URL: #58
Member
Author
|
Landed in afe7356 |
superstar-dev-work
added a commit
to superstar-dev-work/llhttp
that referenced
this pull request
Jul 29, 2025
Use `LLHTTP_STRICT_MODE` C define to switch between modes instead of separate compilation targets. Remove `bitcode` output as it is slower than C version anyway. See: envoyproxy/envoy#5155 (comment) PR-URL: nodejs/llhttp#58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
LLHTTP_STRICT_MODEC define to switch between modes instead ofseparate compilation targets.
Remove
bitcodeoutput as it is slower than C version anyway.See: envoyproxy/envoy#5155 (comment)