Repository navigation
Adding TMU support for NI-Digital - #2230
elebel-emerson wants to merge 10 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2230 +/- ##
==========================================
+ Coverage 88.11% 88.16% +0.04%
==========================================
Files 88 88
Lines 22832 22950 +118
==========================================
+ Hits 20119 20233 +114
- Misses 2713 2717 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
"Update metadata for nidigital" is a very vague PR title. |
Both, functionally I am updating to the latest metadata that has TMU support, but yes this change is being done to add TMU support. Changed the name to better describe the why and not the how. |
elebel-emerson
left a comment
There was a problem hiding this comment.
Changed version of niDigital metadata to a version that does not generate HistoryRAMMaxSamplesToAcquirePerSite
|
|
||
|
|
||
|
|
||
| tmu_initiate |
There was a problem hiding this comment.
Initiate is a context manager in all our nimi-python APIs.
Did you consider it for this? I have no reason to believe it should be different.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
I've added tests applicable for this pull request
What does this Pull Request accomplish?
Update metadata to latest 27.0 export for NI-Digital
Added some tests making sure function calls and enums work for TMU capabilities
Resulting Changes:
List issues fixed by this Pull Request below, if any.
none
What testing has been done?
PR Checks