Skip to content

Adding TMU support for NI-Digital - #2230

Open
elebel-emerson wants to merge 10 commits into
ni:masterfrom
elebel-emerson:users/elebel/updatingNiDigitalMetadata
Open

elebel-emerson wants to merge 10 commits into
ni:masterfrom
elebel-emerson:users/elebel/updatingNiDigitalMetadata

Conversation

@elebel-emerson

@elebel-emerson elebel-emerson commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Update metadata to latest 27.0 export for NI-Digital
Added some tests making sure function calls and enums work for TMU capabilities
Resulting Changes:

  • nidigital has some documentation changes (mostly/all? adding tmu to documentation)

List issues fixed by this Pull Request below, if any.

none

What testing has been done?

PR Checks

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.16%. Comparing base (cdbd8f2) to head (f96ace1).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...ated/nidigital/nidigital/_grpc_stub_interpreter.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
+ Coverage   88.11%   88.16%   +0.04%     
==========================================
  Files          88       88              
  Lines       22832    22950     +118     
==========================================
+ Hits        20119    20233     +114     
- Misses       2713     2717       +4     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 94.36% <ø> (ø)
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.20% <95.00%> (+0.15%) ⬆️
nidigitalunittests 69.48% <87.23%> (+1.05%) ⬆️
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 94.34% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 82.71% <ø> (ø)
nirfsaunittests 63.37% <ø> (-0.03%) ⬇️
nirfsgsystemtests 81.22% <ø> (+0.03%) ⬆️
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elebel-emerson
elebel-emerson marked this pull request as ready for review October 21, 2026 20:54
@ni-jfitzger

ni-jfitzger commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

"Update metadata for nidigital" is a very vague PR title.
Aren't you adding TMU support?

Comment thread generated/nidigital/nidigital/enums.py Resolved
Comment thread src/nidigital/metadata/attributes.py Resolved
@elebel-emerson elebel-emerson changed the title Update metadata for nidigital Adding TMU support for NI-Digital Oct 22, 2026
@elebel-emerson

Copy link
Copy Markdown
Contributor Author

"Update metadata for nidigital" is a very vague PR title. Aren't you adding TMU support?

Both, functionally I am updating to the latest metadata that has TMU support, but yes this change is being done to add TMU support. Changed the name to better describe the why and not the how.

@elebel-emerson elebel-emerson mentioned this pull request Oct 26, 2026
1 task done
Comment thread generated/nidigital/nidigital/enums.py Resolved

@elebel-emerson elebel-emerson left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed version of niDigital metadata to a version that does not generate HistoryRAMMaxSamplesToAcquirePerSite

Comment thread docs/nidigital/class.rst



tmu_initiate

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initiate is a context manager in all our nimi-python APIs.

Did you consider it for this? I have no reason to believe it should be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants