Skip to content

Pydantic 2.0 Migration #236

Closed
Closed

Description

@Kircheneer

As part of the pydantic 2.0 release, a suite of breaking changes were released. We need to investigate where this breaks diffsync.

Issues already identified

  • extra="allow" is no longer possible
  • The __fields__ attribute is deprecated, furthermore it and its replacement model_fields no longer work with __init_subclass__ for us, because their fields are not populated until after this hook runs (see here for the accompanying discussion)

For more see here.

Activity

  1. Kircheneer commented on Jul 7, 2023

    @Kircheneer
    ContributorAuthor
  2. added this to the 2.0.0 milestone on Aug 18, 2023
  3. Kircheneer commented on Aug 18, 2023

    @Kircheneer
    ContributorAuthor

    Due to a change where fields of type Optional now need explicit None defaults, this change can not be considered backwards-compatible.

  4. Kircheneer commented on Aug 31, 2023

    @Kircheneer
    ContributorAuthor

    Closed with #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions