Skip to content

diffsync.DiffSync naming #233

Closed
Closed

Description

@Kircheneer

Since we are calling subclasses of diffsync.DiffSyncadapters in the examples and even in the docs

When you initialize the Diffsync Adapter class

maybe we should just rename the class to diffsync.Adapter? To me this is clearer.

Activity

  1. added this to the 2.0.0 milestone on Jun 22, 2023
  2. glennmatthews commented on Jun 22, 2023

    @glennmatthews
    Collaborator

    I'd be in favor of this change. :-)

  3. chadell commented on Jun 26, 2023

    @chadell
    Contributor

    It looks good to me too

  4. Kircheneer commented on Aug 24, 2023

    @Kircheneer
    ContributorAuthor

    We should keep the old name around for at least a couple of minor versions I think, but change the docs to point to the new one.

  5. Kircheneer commented on Aug 31, 2023

    @Kircheneer
    ContributorAuthor

    Closed with #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions