Skip to content

split project visibility and review status (attempt 2) - #8393

Open
aecsocket wants to merge 14 commits into
mainfrom
boris/project-status-split-2
Open

aecsocket wants to merge 14 commits into
mainfrom
boris/project-status-split-2

Conversation

@aecsocket

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 19, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request once it meets the queue conditions

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge, with a non-blocking queue-card type fix remaining.

Summary

This PR separates project visibility from review state and records project history.

  • Projects keep visibility separate from their moderation state.
  • Moderators can read an ordered history of project changes.

aecsocket accepted missing or stale SQLx query-cache data because CI checks those failures.

Reviews (3) · Last reviewed commit: "rename listed -> public" · Reviewed by Greptile

Comment thread apps/labrinth/src/routes/v2/projects.rs Resolved
Comment thread packages/ui/src/utils/project-state.ts Resolved
Comment thread apps/labrinth/src/models/v2/projects.rs Resolved
Comment thread apps/labrinth/src/models/v3/projects.rs Resolved
<Badge :type="queueEntry.project.requested_status" class="text-sm" />
<Badge
:type="
queueEntry.project.visibility === 'listed' ? 'approved' : queueEntry.project.visibility

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Queue card has type errors. queueEntry.project gets its type from Labrinth.Moderation.Internal.QueueProject, which still declares status and requested_status but no visibility. Both new accesses therefore produce missing-property errors when Vue checks this component. Update the shared queue type to match the server response alongside this consumer.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/frontend/src/components/ui/moderation/ModerationQueueCard.vue
Line: 46

Comment:
**Queue card has type errors.** `queueEntry.project` gets its type from `Labrinth.Moderation.Internal.QueueProject`, which still declares `status` and `requested_status` but no `visibility`. Both new accesses therefore produce missing-property errors when Vue checks this component. Update the shared queue type to match the server response alongside this consumer.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is 4f7b86e8dfca0bdd4aa226083be144ea1aaf48dd

Persistent

Environment URL
staging https://pr-8393.frontend-staging.rinth.dev
production https://pr-8393.frontend.rinth.dev
storybook https://pr-8393-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://3d1cd58e.frontend-staging.rinth.dev
production https://272e6092.frontend.rinth.dev

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants