Skip to content

feat: troubleshooting tab in instance settings - #8390

Open
IMB11 wants to merge 3 commits into
cal/refactor-content-tab-implfrom
cal/troubleshooting-tab-instance-settings
Open

IMB11 wants to merge 3 commits into
cal/refactor-content-tab-implfrom
cal/troubleshooting-tab-instance-settings

Conversation

@IMB11

@IMB11 IMB11 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member
  • Moves "Share" action from multiselect to instance settings under troubleshooting tab
  • Added per-instnace export debug info action for more fine debugging
CleanShot 2026-11-19 at 16 46 56@2x

@IMB11
IMB11 added this pull request to stack #8391 November 19, 2026 16:46
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

  • Troubleshooting tab in the instance settings modal.
    • "Copy content list" uploads a list of the instance's installed content, with versions, file names, and links, then copies its link.
    • The content list can also be copied as project names, file names, project links, or Markdown links from the button's dropdown.
    • "Export debug info" saves a ZIP of the instance's logs, crash reports, configs, game options, and content list.
    • Exported debug info has sensitive info sanitized.

Changed

  • Moved content list sharing from the Share button on the Content tab to the Troubleshooting tab in instance settings.
  • Debug info exports for an instance now show the instance's name and icon in the Download manager.
  • Selecting a finished debug info export in the Download manager now shows the file in its folder.
  • Moved "Relink shared instance" out of the collapsed "Advanced" section to below Repair in the Installation tab of instance settings.
  • Updated the instance settings and server settings modal titles to use a larger heading that matches the app settings modal.

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

  • Updated the server settings modal title to use a larger heading that matches other settings modals.

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 19, 2026

Copy link
Copy Markdown

Merge Protections

🔴 1 of 1 protections blocking · waiting on ⛓️ dependency

Protection Waiting on
🔴 ⛓️ Depends-On Requirements ⛓️ dependency

🔴 ⛓️ Depends-On Requirements

Waiting for

This rule is failing.

Requirement based on the presence of `Depends-On` in the body of the pull request

@mergify

mergify Bot commented Nov 19, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request once it meets the queue conditions

@IMB11
IMB11 requested review from a team and aecsocket November 19, 2026 16:47
@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 3/5

[Medium impact] The changes affect instance support flows in the desktop app.

The PR should not merge until the remaining launch-setting secret exposure is fixed.

Summary

Adds an instance troubleshooting tab for copying installed-content lists and exporting instance debug ZIPs.

  • Instance settings can copy a list of installed content in several formats.
  • Instance settings can save one instance’s diagnostics as a ZIP file.
  • Unlinked instances can be relinked from installation settings.
  • Tabbed modal headings use larger text, while a dashboard template keeps the same behavior.

Reviews (2) · Last reviewed commit: "fix: rev" · Reviewed by Greptile

Comment thread packages/app-lib/src/util/redactions.rs Resolved
Comment thread packages/app-lib/src/api/debug_info.rs Resolved
Comment thread packages/app-lib/src/api/debug_info.rs Resolved
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is a5c363b6379a111f770f55dc3cc88a829335fc86

Persistent

Environment URL
staging https://pr-8390.frontend-staging.rinth.dev
production https://pr-8390.frontend.rinth.dev
storybook https://pr-8390-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://98d24d27.frontend-staging.rinth.dev
production https://6503f292.frontend.rinth.dev

Comment on lines +560 to +564
archive
.start_file(&file.name, file_options())
.map_err(std::io::Error::from)?;
archive.write_all(&contents)?;
continue;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Config export progress freezes. The new config branch increases processed_bytes but immediately continues without calling on_progress. For instances with many config files, the download manager stays at its previous percentage throughout that work, making the export look stuck. Send throttled progress updates from this branch too, including when a file is left out.

Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/app-lib/src/api/debug_info.rs
Line: 560-564

Comment:
**Config export progress freezes.** The new config branch increases `processed_bytes` but immediately continues without calling `on_progress`. For instances with many config files, the download manager stays at its previous percentage throughout that work, making the export look stuck. Send throttled progress updates from this branch too, including when a file is left out.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants