Repository navigation
Conversation
Pull request changelogAppAdded
Changed
DeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChanged
DeprecatedRemovedFixedSecurity |
Merge Protections🔴 1 of 1 protections blocking · waiting on ⛓️ dependency
🔴 ⛓️ Depends-On RequirementsWaiting for
This rule is failing.Requirement based on the presence of `Depends-On` in the body of the pull request
|
|
Tick the box to add this pull request to the merge queue (same as
|
[Medium impact] The changes affect instance support flows in the desktop app. The PR should not merge until the remaining launch-setting secret exposure is fixed.
|
Frontend previewsLast deployed commit is a5c363b6379a111f770f55dc3cc88a829335fc86 Persistent
Latest commit
|
| archive | ||
| .start_file(&file.name, file_options()) | ||
| .map_err(std::io::Error::from)?; | ||
| archive.write_all(&contents)?; | ||
| continue; |
There was a problem hiding this comment.
Config export progress freezes. The new config branch increases
processed_bytes but immediately continues without calling on_progress. For instances with many config files, the download manager stays at its previous percentage throughout that work, making the export look stuck. Send throttled progress updates from this branch too, including when a file is left out.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/app-lib/src/api/debug_info.rs
Line: 560-564
Comment:
**Config export progress freezes.** The new config branch increases `processed_bytes` but immediately continues without calling `on_progress`. For instances with many config files, the download manager stays at its previous percentage throughout that work, making the export look stuck. Send throttled progress updates from this branch too, including when a file is left out.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Uh oh!
There was an error while loading. Please reload this page.