Repository navigation
refactor: mobile navigation - #8315
Open
creeperkatze wants to merge 2 commits into
Open
creeperkatze wants to merge 2 commits into
creeperkatze wants to merge 2 commits into
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Author
chrome_4bV7spB3St.mp4 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the mobile navigation out of the default layout into its own component and updates it to the current styling with borders, replacing the old CSS with Tailwind.
Following the modern component structure, its a
mobile-navigation/folder withindex.vueand localsheet.vueandtab.vuesubcomponents. The bare icon tabs are now proper buttons as described in BUTTONS.md, with a selected state for the current page and even spacing around them.Also uses the dashboard icon for the dashboard tab instead of the analytics icon and adds a hosting tab.