Skip to content

feat: prohibited images validator - #8294

Open
tdgao wants to merge 4 commits into
mainfrom
truman/photodna-validator
Open

tdgao wants to merge 4 commits into
mainfrom
truman/photodna-validator

Conversation

@tdgao

@tdgao tdgao commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 1/5

[High impact] The screening reaches image uploads across several major website workflows.

Fix the screening bypass, ship the native SDK, and correct the HTTP test before merging.

Summary

Adds PhotoDNA screening before image storage and shows prohibited-image errors in upload screens.

  • Image uploads now stop when PhotoDNA confirms a prohibited image.
  • Image upload failures now show clearer reasons across the website.

Reviews (1) · Last reviewed commit: "feat: add photodna blocking validation" · Reviewed by Greptile

Comment thread apps/labrinth/src/util/photodna.rs Resolved
Comment thread apps/labrinth/src/util/photodna.rs Resolved
Comment thread apps/labrinth/src/util/photodna.rs Resolved
tdgao and others added 3 commits November 10, 2026 17:52
photodna-sys refuses to load the library when PHOTODNA_SDK_ROOT is
missing at build time, even with a runtime library_dir. Replace it with
a small libloading wrapper so builds don't need the proprietary SDK.
Log initialization failures at error level and fail the upload instead
of silently skipping screening.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants