Skip to content

feat(frontend): make the search component push to history instead of replacing current state - #8259

Open
slonkazoid wants to merge 1 commit into
modrinth:mainfrom
slonkazoid:main
Open

slonkazoid wants to merge 1 commit into
modrinth:mainfrom
slonkazoid:main

Conversation

@slonkazoid

Copy link
Copy Markdown

see #8258

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request

@Prospector

Copy link
Copy Markdown
Member

it's more complicated than this, because updating the state for every character typed into the query field would pollute your history with nonsense. like, ideally it should only commit the page to history when there's something that indicates it's your final intended query, like a scroll action or clicking on a project or something.

@slonkazoid

slonkazoid commented Nov 14, 2026 •

Copy link
Copy Markdown
Author

an eager deferred repeating debouncing algorithm would suffice. current debouncing algorithm is setTimeout(.., 200) iirc

when character typed:
update # this makes it eager
   race: 200ms timeout or next character
   if next character: goto race
   else: update

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants