Repository navigation
[Conformance] Listen on the standalone stream in the conformance client - #745
Merged
chr-hertel merged 2 commits intoNov 16, 2026
Conversation
…defaults scenario
gowtham-padala
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 16, 2026 07:04
chr-hertel
approved these changes
Nov 16, 2026
chr-hertel
left a comment
Member
There was a problem hiding this comment.
Thanks @gowtham-padala - good one! The conditional wasn't even needed, patched that quickly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elicitation-sep1034-client-defaultswas the last entry in the 2025-11-25 client baseline. The client never got to fill in the defaults: it timed out waiting for thetools/callresult.The scenario's server calls
elicitation/createwithout tying it to the tool call, so the TypeScript server transport sends it on the standalone GET stream. The conformance client creates itsHttpTransportwithoutlisten, so that stream is never opened and the request is dropped. The client keeps waiting for a tool result that never comes, and the runner gives up after 30 seconds:#462 added the defaults handling and kept the baseline entry because the transport couldn't open the GET stream yet. #543 then added
listentoHttpTransport, but the conformance client was never switched over. This enableslistenfor every scenario intests/Conformance/client.phpand removes the baseline entry.The other scenarios are unaffected: a server that rejects the GET is only logged, and the transport skips the standalone stream on 2026-07-28.