Repository navigation
Report an error for private identifiers in JSX tag and attribute names - #65395
Open
Elecmonkey (elecmonkey) wants to merge 1 commit into
Open
Elecmonkey (elecmonkey) wants to merge 1 commit into
Elecmonkey (elecmonkey) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65396
Analysis
JSX tag and attribute names starting with
#(e.g.<#a></#a>,<a #b />) are accepted without a syntax error, and--jsx reactemits invalid JS such asReact.createElement(#a, null).<a.#b />already reportsIdentifier expected.tokenIsIdentifierOrKeywordalso matchesKindPrivateIdentifier, soScanJsxIdentifierandparseIdentifierNameErrorOnUnicodeEscapeSequencetreat the token as an identifier.Fix
Exclude
KindPrivateIdentifierin both places and reportIdentifier expected., matching<a.#b />.Copilot Checklist
I successfully ran the applicable command at the end of my session, and it completed without error: