Skip to content

Watch extended configs if present - #41493

Merged
Sheetal Nandi (sheetalkamat) merged 10 commits into
microsoft:masterfrom
bloomberg:watch-tsconfig-extends
Dec 11, 2020
Merged

Sheetal Nandi (sheetalkamat) merged 10 commits into
microsoft:masterfrom
bloomberg:watch-tsconfig-extends

Conversation

@molisani

@molisani Michael Molisani (molisani) commented Nov 11, 2020 •

Copy link
Copy Markdown
Contributor

Fixes #17753

Inspects extendedSourceFiles from configFile in CompilerOptions and starts a watcher for each file. Watch callback invokes scheduleProgramReload just like the watcher for the main config file. Watcher pattern modelled after watcher map for missing files. Also provides shared watcher map for situations where multiple projects are open at once (tsbuild/tsserver).

Added new test cases, including chain of extended configs and ones copied from watchEnvironment/watchOptions with extended configs to verify they are being watched.

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Apart from watching config file for the project updates, we probably should also watch extended config file

3 participants