Repository navigation
Fix binding of this-assignments w/computed properties - #35639
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoDec 11, 2019
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit into
Nathan Shively-Sanders (sandersn) merged 1 commit into
Conversation
Top-level this-assignments do not support computed properties. But the binder forgets to check for computed properties and tries to bind them normally. This hits a helpful assert. This change stop binding this-properties with computed properties at the top-level. There's nothing sensible we could do with them; we're unable to late-bind entries to the global scope or to modules.
Nathan Shively-Sanders (sandersn)
requested review from
Andrew Branch (andrewbranch) and
Wesley Wigham (weswigham)
December 11, 2019 23:24
Andrew Branch (andrewbranch)
approved these changes
Dec 11, 2019
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.7 |
Contributor
|
Hey Nathan Shively-Sanders (@sandersn), I've opened #35640 for you. |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Dec 11, 2019
Component commits: 7c31be3 Fix binding of this-assignments w/computed properties Top-level this-assignments do not support computed properties. But the binder forgets to check for computed properties and tries to bind them normally. This hits a helpful assert. This change stop binding this-properties with computed properties at the top-level. There's nothing sensible we could do with them; we're unable to late-bind entries to the global scope or to modules.
Nathan Shively-Sanders (sandersn)
pushed a commit
that referenced
this pull request
Dec 12, 2019
Component commits: 7c31be3 Fix binding of this-assignments w/computed properties Top-level this-assignments do not support computed properties. But the binder forgets to check for computed properties and tries to bind them normally. This hits a helpful assert. This change stop binding this-properties with computed properties at the top-level. There's nothing sensible we could do with them; we're unable to late-bind entries to the global scope or to modules.
Nathan Shively-Sanders (sandersn)
deleted the
fix-binding-this-computed-property-assignment
branch
December 12, 2019 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding of top-level this-assignments forgets to check for computed properties and tries to bind them normally. Then it hits a helpful assert which prevents that.
This change stops binding this-properties with computed properties at the top-level. There's nothing sensible we could do with them; we're unable to late-bind entries to the global scope or to modules.
Fixes #35630