Repository navigation
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #11354, but simpler.
Map<T>instead ofMap<K, V>, withKassumed to bestring. For number-keyed maps we now use sparse arrays.Set-- this can be done later.sortInV8ObjectInsertionOrder; changes baselines instead. We won't be able to pass all tests when using the shim map, but we no longer run tests on node 0.10 anyway.Added functions
arrayFromIteratorto anArray.arrayFrom(map.keys())replacesObject.keys(map).arrayFrom(map.values())also lets us removereduceProperties, which was only used to compute that.forEachEntry,forEachKeyfor-inloops with early termination,forEachProperty, andsomeProperties.copyEntriescopyProperties.createMultiMapmultiMapAddandmultiMapRemove.mapsAreEqualequalOwnProperties. Used only inreuseProgramStructure.ts, so moved it there.multiMapSparseArrayAddmultiMapAddon what is now a sparse array. Used only infactory.ts, so moved it there.mapEntriesmapObject.We also get rid of
isEmptyand replace withmap.size === 0.