Skip to content

notApplicableReason not included in protocol.d.ts #40640

Closed

Description

@mjbvz

Looks like RefactorActionInfo.notApplicableReason never made it into protocol.d.ts. This property does seem to be sent along by the TS Server, it is just the typings for the property that is missing

Confirmed with TS 4.0.3

Activity

  1. DanielRosenwasser commented on Sep 21, 2020

    @DanielRosenwasser
    Member

    Jesse Trinity (@jessetrinity) can you fix this and cherry-pick the changes to release-4.0?

  2. jessetrinity commented on Sep 21, 2020

    @jessetrinity
    Contributor

    Daniel Rosenwasser (@DanielRosenwasser) the only way I can tell how to do this is running gulp LKG. Do I update protocol.ts and run LKG to get the new protocol.d.ts. (along with everything else LKG produces)?

  3. DanielRosenwasser commented on Sep 21, 2020

    @DanielRosenwasser
    Member

    The LKG can be done prior to the publish - in other words, don't worry about protocol.d.ts, just fix up protocol.ts.

  4. locked as resolved and limited conversation to collaborators on Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugA bug in TypeScriptDomain: APIRelates to the public API for TypeScriptFix AvailableA PR has been opened for this issue

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions