You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tests don't pass when TS is retargeted to es6 and moduleResolution: node #32206
In theory, every node version we test on supports full es6. However, if tsconfig-base.json is edited to retarget TS's build for ES6 environments, many of our services tests fail - this would seem to indicate a deficiency in our analysis somewhere. :(
This is going to spawn more work items, but since I noticed it, the first step is to setup a CI build targeting es6. Then I'll need to work on getting it green, while opening issues for the missing analysis that allowed those bugs through (since it indicates a difference in behavior between our es5 and es6 emit that we should callout in our analysis) 🙁
Looks like a couple in the compiler are due to TDZ violations in the declaration emitter. I imagine the services ones may be similar (and also doubt our analysis can catch them, since it's all about cross-call sequencing issues).
Activity
weswigham commentedon Jul 2, 2019
This is going to spawn more work items, but since I noticed it, the first step is to setup a CI build targeting es6. Then I'll need to work on getting it green, while opening issues for the missing analysis that allowed those bugs through (since it indicates a difference in behavior between our es5 and es6 emit that we should callout in our analysis) 🙁
weswigham commentedon Jul 2, 2019
Looks like a couple in the compiler are due to TDZ violations in the declaration emitter. I imagine the services ones may be similar (and also doubt our analysis can catch them, since it's all about cross-call sequencing issues).