Repository navigation
Conversation
vishwach
requested review from
NiteshMehta,
adganta,
ashokrprogress,
hmadala001,
prgs-rsingh and
rjrudin
as code owners
November 5, 2026 06:19
vishwach
marked this pull request as draft
November 5, 2026 06:20
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The re-enabled test previously restarted MarkLogic, and only version 12 validation is documented, so MLE-24579 fix coverage or a version guard must be confirmed for older supported servers.
No open issues 🎉
What changed in this PR
Updates server-bug tracking in the core Java client tests and restores zero-row query coverage following the reported MarkLogic 12 fix.
Changes:
- Re-enables
RowBatcherTest.noRowsReturnedby removing its@Disabledannotation. - Clarifies the server bugs blocking two other tests without changing their disabled status.
| File | Description |
|---|---|
marklogic-client-api/src/test/java/com/marklogic/client/test/rows/RowManagerTest.java |
Clarifies the Optic facet-by bug in the disabled-test reason. |
marklogic-client-api/src/test/java/com/marklogic/client/test/document/ReadJsonAsBinaryTest.java |
Clarifies the incorrect document-format response in the disabled-test reason. |
marklogic-client-api/src/test/java/com/marklogic/client/test/datamovement/RowBatcherTest.java |
Re-enables the zero-row query regression test. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For RowBatcherTest.noRowsReturned: Running an Optic query used to return zero rows previously which crashed MarkLogic Server due to an unhandled exception in SPARQL/inference query preparation (Fix as part of this : MLE-24579). Verified that the crash is resolved in MarkLogic 12 with no server restarts or side effects. Removed @disabled and added @ExtendWith(RequiresML12.class) so the test executes on ML 12+ while safely skipping on older server matrices to prevent CI instability.
For ReadJsonAsBinaryTest (MLE-27191) and RowManagerTest(MLW-214) the fix is not in place yet, thus added a detailed comment and left as-is.