Repository navigation
Conversation
vishwach
requested review from
NiteshMehta,
adganta,
ashokrprogress,
hmadala001,
prgs-rsingh and
rjrudin
as code owners
November 4, 2026 08:50
vishwach
marked this pull request as draft
November 4, 2026 08:50
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are blocking approval.
No open issues 🎉
What changed in this PR
Removes dead code and unused resources from the functional-test module without changing production code or JUnit-discovered tests.
Changes:
- Deletes unfinished methods without
@Testand obsolete commented-out test code. - Removes the associated database-disabling helper and unused query-options fixture.
- Deletes a stale comment about issue #347; query-option behavior is unchanged.
Paths below are relative to marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/.
| File | Description |
|---|---|
functionaltest/queryoptions/collectionConstraintWithWordConstraintAndGoogleGrammarOpt.xml |
Deletes the unused query-options fixture. |
fastfunctest/TestQueryOptionBuilder.java |
Removes only the stale issue #347 comment block. |
fastfunctest/TestPOJOReadWriteWithTransactions.java |
Removes an undiscovered collection-search transaction test. |
fastfunctest/TestOpticOnLiterals.java |
Removes an unfinished built-in functions test. |
fastfunctest/TestAppServerConstraints.java |
Removes the undiscovered Google-grammar constraint test. |
datamovement/functionaltests/WriteHostBatcherTest.java |
Removes an unfinished database-disable test and its helper class. |
datamovement/functionaltests/StringQueryHostBatcherTest.java |
Removes an unfinished query-failure test and commented-out batcher contention test. |
Review effort: Balanced
ashokrprogress
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up historical dead test debt across the test suite by permanently removing 7 dead code sites (unexecuted Early Access prototypes, unfinished plan builders, commented-out test stubs, orphaned batcher helpers, and obsolete comment banners) along with their unused imports and fixtures.
None of these sites were active tests in CI. Their removal eliminates codebase clutter and confusion with zero loss in test coverage.
Detailed Breakdown of Purged Dead Code Sites
StringQueryHostBatcherTest.java:741testQueryBatcherQueryFailures// @TestQueryBatcherTestandHostAvailabilityListenerTest.WriteHostBatcherTest.java:2170testDisableDBDuringInsert// @TestWriteBatcherFailureTestand activeWriteHostBatcherTestlistener suites.WriteHostBatcherTest.java(Additional site / Orphaned helper)
testDisableDBDuringInsertwas purged; removed to keep-Werrorclean.TestOpticOnLiterals.java:1093testBuiltInFns@Test, zero assertions)OpticOnLiteralsTest,OpticPlanTest, andPlanGeneratedTest.TestAppServerConstraints.java:155testWithWordConstraintAndGoogleGrammarSearchQueryDefinitionTestandTestQueryOptionBuilder.TestPOJOReadWriteWithTransactions.java:294test4POJOSearchWithCollectionsandTransaction@Test, never run)PojoRepositoryTest.TestQueryOptionBuilder.java:1768(Comment block only)
Begin/End) referencing tests deleted before 4.0.2TestQueryOptionBuilder. Active test logic was preserved to avoid conflict with MLE-32873.