Repository navigation
MLE-33564 Fix the 5 fixable disabled tests - #1985
Open
hmadala001 wants to merge 2 commits into
Open
hmadala001 wants to merge 2 commits into
hmadala001 wants to merge 2 commits into
Conversation
BulkReadWriteTest (testA_BulkLoad, testB_BulkRead, testC_BulkSearch): - Load cities_above_300K.txt in @BeforeAll so the tests no longer depend on running in method-name order; testA_BulkLoad now verifies the loaded count. - Removed @disabled. TestBiTemporal (testPeriodRangeQuerySingleAxisBasedOnALNContains, testPeriodRangeQueryMultiplesAxesBasedOnALNContains): - Query periods are now derived by offsets from the valid times the test writes, and are built in UTC rather than the JVM default timezone, which made the tests fail whenever the JVM was not running in UTC. - Removed @disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hmadala001
requested review from
NiteshMehta,
adganta,
ashokrprogress,
prgs-rsingh,
rjrudin and
vishwach
as code owners
November 4, 2026 08:04
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the changes re-enabling bulk and temporal test coverage.
No open issues 🎉
What changed in this PR
Re-enables five disabled tests in the core client and functional test suites by removing bulk-test ordering dependencies and making temporal query periods independent of the JVM’s default timezone.
Changes:
- Loads city data once in
@BeforeAlland changes the bulk-load test to verify the loaded count. - Derives temporal query boundaries from shared valid-time constants using UTC and one-second offsets.
- Removes
@Disabledfrom three bulk tests and two temporal tests.
| File | Description |
|---|---|
marklogic-client-api/src/test/java/com/marklogic/client/test/BulkReadWriteTest.java |
Initializes shared city data before all tests and re-enables bulk load, read, and search coverage. |
marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/TestBiTemporal.java |
Adds UTC query-period construction and re-enables two ALN_CONTAINS tests. |
Review effort: Balanced
The Validate Copyright Headers check requires modified files to carry the current year. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BulkReadWriteTest (testA_BulkLoad, testB_BulkRead, testC_BulkSearch):
TestBiTemporal (testPeriodRangeQuerySingleAxisBasedOnALNContains, testPeriodRangeQueryMultiplesAxesBasedOnALNContains):