Repository navigation
MLE-33565 Resolve the 5 remaining disabled tests - #1984
Open
hmadala001 wants to merge 3 commits into
Open
hmadala001 wants to merge 3 commits into
hmadala001 wants to merge 3 commits into
Conversation
Stabilised: - TestOpticOnViews.testgroupByUnion now uses order-independent assertions - BulkIOInputCallerTest.bulkInputEndpointTestWithAnyDocument now uses its own collections, cleans up beforehand, and asserts on the union of written inputs rather than on how batches are distributed across call contexts Retired: - ClientApiFunctionalTest.TestE2ENumberOfConcurrentUsers: tests the app server concurrent-request-limit feature, not the Java Client; flaky on Jenkins - DocumentMetadataHandleTest.testMetadataPropertiesExtraction (and test.bin): tests a v1/documents feature and causes OOM in CI - SetMaxBatchesTest.testWithQuery: setMaxBatches with a query is a known limitation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hmadala001
requested review from
NiteshMehta,
adganta,
ashokrprogress,
prgs-rsingh,
rjrudin and
vishwach
as code owners
November 3, 2026 05:13
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the test-only changes that re-enable two tests and remove three disabled tests.
No open issues 🎉
What changed in this PR
Resolves five disabled tests in the Java Client’s core and functional test suites by stabilizing two and retiring three. No production code changes are included.
Changes:
- Re-enables the Optic union test with order-independent assertions.
- Re-enables the bulk-input test with isolated collections, cleanup, and assertions that every input is written exactly once.
- Removes three disabled tests covering server behavior or a known limitation, plus an unused fixture and helper.
| File | Description |
|---|---|
marklogic-client-api/src/test/resources/test.bin |
Removes the retired metadata test’s binary fixture. |
marklogic-client-api/src/test/java/com/marklogic/client/test/io/DocumentMetadataHandleTest.java |
Removes the disabled metadata-extraction test and related imports. |
marklogic-client-api/src/test/java/com/marklogic/client/test/dataservices/BulkIOInputCallerTest.java |
Isolates and re-enables the bulk-input test with distribution-independent assertions. |
marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestOpticOnViews.java |
Re-enables the union test and replaces order-sensitive row checks. |
marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/datamovement/SetMaxBatchesTest.java |
Removes the disabled query-based test while retaining iterator coverage. |
marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/ClientApiFunctionalTest.java |
Removes the disabled concurrent-request-limit test and its configuration helper. |
Review effort: Balanced
hmadala001
marked this pull request as draft
November 3, 2026 05:16
rjrudin
reviewed
Nov 3, 2026
| } | ||
|
|
||
| @AfterAll | ||
| public static void cleanup(){ |
Contributor
There was a problem hiding this comment.
I would rework this test class to extend AbstractClientTest which will clean the database before the test starts instead of after. That's a better practice because if the database is cleaned afterwards and the test fails, it's much harder to debug since the data is all gone. Extending that class also avoids duplication of deletion code like this.
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Sure, though that's actually not necessary either. I know now the dataservices tests do a lot of that - loading modules and then deleting them - but they could all be setup via the test-app as part of mlDeploy, and then the tests wouldn't need all the additional code. Not important to change, just an FYI.
Addresses review feedback: AbstractClientTest cleans the database before each test instead of after, so data from a failing test is still available for debugging, and it removes the duplicated document-deletion code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rjrudin
previously approved these changes
Nov 4, 2026
hmadala001
marked this pull request as ready for review
November 5, 2026 09:27
The Validate Copyright Headers check requires modified files to carry the current year. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilised:
Retired: