Repository navigation
Conversation
Rubix982
approved these changes
Nov 18, 2026
Contributor
|
LGTM. 👍 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176.
A detection can have pixel geometry and a label even when the response has no image location. The SDK currently gives that detection an empty geometry object. Constructing the collection then raises
KeyError: 'type', so the caller loses the located detections in the same response.Keep the detection with a null geometry, as specified for an unlocated feature in RFC 7946 §3.2. Preserve its properties and keep point geometry for detections with a location.
I checked
get_detections_with_map_feature_idon macOS arm64 with a two-detection response supplied at the HTTP boundary. On main, the located-only control returned a point and the mixed response raised. With this change, the mixed response returns both features, with the point and null geometry respectively. The two regression tests and 12 offline API configuration tests passed.