Skip to content

Allow 60 seconds for Arbitrum L1 progress - #97

Merged
j0sh merged 4 commits into
mainfrom
ja-codex/l1-progress-deadline
Nov 21, 2026
Merged

j0sh merged 4 commits into
mainfrom
ja-codex/l1-progress-deadline

Conversation

@j0sh

@j0sh j0sh commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The signer's chain view briefly became unavailable during two 30–31-second pauses in Arbitrum's reported L1 height. L2 kept producing fresh blocks throughout both pauses.

Block height must advance within 30 seconds, or within 60 seconds if the observer starts with a separate L1 height.

Testing

  • Cover the 59/60-second L1 and 29/30-second native boundaries, early and late lower L1 readings after a native start, and L1 recovery.
  • go test -race ./... passed.

Copilot AI balanced review requested due to automatic review settings November 21, 2026 01:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the payment-observer progress-deadline change.

No open issues 🎉

What changed in this PR

Allows payment observers that start with a separate L1 height to tolerate longer pauses in Arbitrum’s reported L1 progress, reducing temporary chain-view unavailability while L2 blocks remain fresh.

Changes:

  • Fixes the progress deadline at startup: 60 seconds for separate L1 heights and 30 seconds for native heights.
  • Preserves the existing 30-second observation and head-timestamp freshness limits.
  • Expands deadline-boundary and native-to-L1 transition tests, and documents the lifetime-fixed deadline.
File Description
eth/​payment_observer.go Selects the progress deadline from the first accepted observation’s clock.
eth/​payment_observer_test.go Covers 59/60-second L1 and 29/30-second native boundaries, plus later lower L1 readings.
docs/​metrics.md Documents progress deadlines and unchanged freshness requirements.

Review effort: Balanced

@j0sh
j0sh deployed to docker-publish November 21, 2026 01:27 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 21, 2026 01:27 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 21, 2026 01:27 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 21, 2026 01:27 — with GitHub Actions Active
Copilot AI balanced review requested due to automatic review settings November 21, 2026 01:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the change extending the Arbitrum L1 progress deadline.

No open issues 🎉

Review effort: Balanced

@j0sh
j0sh deployed to docker-publish November 21, 2026 01:34 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 21, 2026 01:34 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 21, 2026 01:34 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 21, 2026 01:35 — with GitHub Actions Active
Copilot AI balanced review requested due to automatic review settings November 21, 2026 02:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review identifies no active issues in the payment observer timing changes.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 21, 2026 02:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the payment-observer deadline changes.

No open issues 🎉

Review effort: Balanced

@j0sh
j0sh deployed to docker-publish November 21, 2026 02:33 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 21, 2026 02:34 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 21, 2026 02:34 — with GitHub Actions Active
@j0sh
j0sh deployed to docker-publish November 21, 2026 02:34 — with GitHub Actions Active
@j0sh
j0sh enabled auto-merge (squash) November 21, 2026 02:35
@j0sh
j0sh merged commit 889d0fa into main Nov 21, 2026
14 checks passed
@j0sh
j0sh deleted the ja-codex/l1-progress-deadline branch November 21, 2026 02:36

This branch was successfully deployed

1 active deployment
docker-publish — 6fb79a3f Deployed Nov 21, 2026 by j0sh via docker-pr / promote #211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants