Repository navigation
Allow 60 seconds for Arbitrum L1 progress - #97
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the payment-observer progress-deadline change.
No open issues 🎉
What changed in this PR
Allows payment observers that start with a separate L1 height to tolerate longer pauses in Arbitrum’s reported L1 progress, reducing temporary chain-view unavailability while L2 blocks remain fresh.
Changes:
- Fixes the progress deadline at startup: 60 seconds for separate L1 heights and 30 seconds for native heights.
- Preserves the existing 30-second observation and head-timestamp freshness limits.
- Expands deadline-boundary and native-to-L1 transition tests, and documents the lifetime-fixed deadline.
| File | Description |
|---|---|
eth/payment_observer.go |
Selects the progress deadline from the first accepted observation’s clock. |
eth/payment_observer_test.go |
Covers 59/60-second L1 and 29/30-second native boundaries, plus later lower L1 readings. |
docs/metrics.md |
Documents progress deadlines and unchanged freshness requirements. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The signer's chain view briefly became unavailable during two 30–31-second pauses in Arbitrum's reported L1 height. L2 kept producing fresh blocks throughout both pauses.
Block height must advance within 30 seconds, or within 60 seconds if the observer starts with a separate L1 height.
Testing
go test -race ./...passed.