Repository navigation
Add heartbeat seq tracking - #68
Merged
Merged
Conversation
Stale heartbeats can arrive after an app is removed, making the app available for use again. Heartbeats now carry a strictly increasing seq number; invalid seq numbers are rejected and the heartbeat is not applied.
There was a problem hiding this comment.
🟡 Changes recommended
The stale-snapshot rejection path lacks regression coverage for sequence ordering, state preservation, app resurrection prevention, and invalid heartbeats not advancing the counter.
1 open issue
What changed in this PR
This PR adds heartbeat sequence tracking to prevent stale runner snapshots from making removed apps available again after sequence tracking is enabled.
Changes:
- Track accepted sequences and reject non-increasing or missing values after opt-in.
- Return the accepted sequence in successful responses and sequence-conflict errors.
- Document heartbeat sequence behavior.
| File | Description |
|---|---|
orchestrator/registry.go |
Tracks and validates heartbeat sequences before applying state changes. |
orchestrator/http.go |
Includes the last accepted sequence in conflict responses. |
docs/http-api.md |
Documents sequence ordering, response echoes, and sequence resets. |
Review effort: Balanced
Comment on lines
+455
to
+456
| if current.Seq != nil && (req.Seq == nil || *req.Seq <= *current.Seq) { | ||
| return heartbeatResponse{}, http.StatusConflict, seqConflict(*current.Seq) |
There was a problem hiding this comment.
🟡 Changes recommended
The API documentation conflates local restarts with a new credential scope and must explain that runners reusing credentials need to persist the sequence counter or recover it from an HTTP 409 response.
2 open issues
Review effort: Balanced
This was referenced Nov 10, 2026
1 of 23 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stale heartbeats can arrive after an app is removed, making the app available for use again.
Heartbeats now carry a strictly increasing seq number; invalid seq numbers are rejected and the heartbeat is not applied.