Repository navigation
Conversation
Fix a compiler warning about an uninitialised err_msg variable by printing the error where it is handled: drivers/platform/x86/intel/int3472/discrete.c:440:24: warning: ‘err_msg’ may be used uninitialized [-Wmaybe-uninitialized] 440 | return dev_err_probe(int3472->dev, ret, err_msg); Fixes: 5de691b ("platform/x86: Add intel_skl_int3472 driver") Cc: stable@vger.kernel.org Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> Acked-by: Rafael J. Wysocki (Intel) <rafael@kernel.org> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> (cherry picked from commit 70e6384) Signed-off-by: Firas Sharary <firassharary3@gmail.com>
There have been several reports of the sensor not properly powering on, on laptops where an INT3472 handshake GPIO is used. Both with ov08x40 and hi556 sensors. Testing has shown that a delay of 200 ms is necessary in some cases. The handshake GPIO is typically used to signal an extra bridge or other IC with that IC running the full sensor power sequence based on the handshake signal and also possible controlling I2C pass-through. It seems that in some cases that extra IC takes up to 200 ms to before the sensor is fully powered up and ready for I2C communication. With the default handshake signal delay increased to 200 ms the quirk to increase it to 45 ms for the ov08x40 is no longer necessary and is actually undesirable since some ov08x40 setups also need the longer delay, drop it. Fixes: 30359c2 ("platform/x86: int3472: Increase ov08x40 handshake GPIO delay to 45 ms") Closes: https://lore.kernel.org/platform-driver-x86/20260816204247.2844986-1-opensource@inspiredexperts.com/ Reported-by: James Alexander <opensource@inspiredexperts.com> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2333331 Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2333647 Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> (cherry picked from commit 844982d) Signed-off-by: Firas Sharary <firassharary3@gmail.com>
On IPU6 designs carrying an OV7251 IR sensor (ACPI HID INT347E) the INT3472 describes the sensor's single gated rail as a power-enable GPIO, which the driver registers as a regulator with con_id "avdd". The ov7251 driver and its DT bindings name the sensor supplies vdda, vddd and vdddo, so the lookup finds nothing, the rail is never enabled, and probe fails on the first I2C access: int3472-discrete INT3472:02: avdd \_SB.GPI0 pin 131 active-high ov7251 i2c-INT347E:00: supply vdda not found, using dummy regulator ov7251 i2c-INT347E:00: probe with driver ov7251 failed with error -121 Map the power-enable GPIO to con_id "vdda" for INT347E, the same way the existing entries map it to "vdd" for the mt9m114 and to "vana" for the imx471. The sensor's other two supplies keep falling back to the dummy regulator, which is correct here: the firmware gates a single rail. The table already has an INT347E entry mapping the reset GPIO to "enable", added when the ov7251 was brought up on these machines; this is the same class of firmware-vs-binding name mismatch for the remaining pin. Tested on a Microsoft Surface Pro 7+ (Tiger Lake, IPU6): with this change the IR sensor probes, the illuminator strobes, and the camera streams 640x480 at 30 fps through libcamera. The same failure was reproduced independently on a second Pro 7+ running stock firmware and a distro kernel, with no out-of-tree code, in [1]. Developed with the assistance of an AI tool (Claude) and verified on hardware. Link: linux-surface/linux-surface#1702 [1] Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com> Signed-off-by: D. Manresa <dmanresa@gmail.com> Tested-by: Jakob Berg Jespersen <dev@berg.pm> # Surface Pro 7+, probe/power-on Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> (cherry picked from commit 59cab09) Signed-off-by: Firas Sharary <firassharary3@gmail.com>
…dvdd" On the Surface Pro 7+ the INT3472 for the rear camera (INT347A, ov8865) describes a second power rail as GPIO type 0x08 (POWER1). The 0x08 handling added for the Surface Pro 9 registers that rail as "pwr1", the name its ov13858 asks for, but ov8865 requests "dvdd". It gets a dummy regulator instead and the sensor is never fully powered. Add a GPIO map entry that names the 0x08 rail "dvdd" for INT347A only. The Surface Pro 9 keeps its "pwr1" rail unchanged. Upstream solves this generically with commit 34e3139 ("platform/x86: int3472: support the POWER1 GPIO type"), which maps 0x08 to "dvdd" for all devices; this entry can be dropped together with the Pro 9 0x08 handling once that commit is picked up. Assisted-by: LLM Signed-off-by: Firas Sharary <firassharary3@gmail.com>
T-Caster
force-pushed
the
int3472-sp7plus-7.3
branch
from
November 15, 2026 17:06
3874a43 to
b78beef
Compare
Author
|
I reworked this so it no longer touches the Surface Pro 9 code. Instead of backporting the mainline POWER1 commit, which replaced the Pro 9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three backports from mainline plus one small linux-surface commit that make the rear (OV8865) and infrared (OV7251) cameras of the Surface Pro 7+ power up on the 7.3 kernels. The front camera is covered by #193. The Surface Pro 9 code is not changed.
On the Pro 7+ the int3472 nodes describe two rails the driver does not hand to the sensors under the names they ask for:
INT347A: the second rail has GPIO type0x08(POWER1). The Pro 9 support registers it aspwr1, but ov8865 asks fordvdd, gets a dummy regulator and the sensor is never fully powered.INT347E: the power-enable GPIO is registered asavdd, but ov7251 asks forvdda. The first I2C write fails and the sensor never probes.1 and 2 are already in 7.3.y stable (they are in
v7.3-surface, which is on 7.3.4), so they should drop out when this branch is rebased; they are here because 3 does not apply to the 7.3.0 base without them.4 is linux-surface only. It adds one entry to the int3472 GPIO map: for
INT347Aonly, type0x08gets the con_iddvdd. The rail is then registered by the existing Pro 90x08code, so nothing changes for the Pro 9 (ov13858 still getspwr1). Mainline solves this generically with torvalds/linux@34e31390a3b9 ("support the POWER1 GPIO type", maps0x08todvddfor every device). When that arrives with 7.4, this entry can go together with the Pro 90x08code.Testing, Surface Pro 7+ (IPU6 Tiger Lake
8086:9a19, SKUSurface_Pro_7+_1960), Debian 13, linux-surface 7.3.4-1, with the int3472 module built from this branch:i2c-INT347E:00has no driver bound; the rear camera lists in libcamera but a capture gets no frames.GPIO type 0x08 detected on pin 0xaf, con_id=dvdd, all three sensors probe (OV7251 revision 7 (1F) detected,Instantiated dw9719 VCM). Raw capture from the ISYS nodes over repeated start/stop cycles delivered every frame for the rear (3264x2448, 15 fps) and infrared (640x480) cameras, and Howdy face authentication works with the infrared camera.Note for anyone trying the infrared camera: its illuminator additionally needs the ov7251 strobe support, which is not part of this PR.