Repository navigation
Conversation
The OVTID858 entry declares 4 link frequencies but gives only one:
IPU_SENSOR_CONFIG("OVTID858", 4, 540000000),
The count does not fit the array it indexes, which holds 3 entries
(include/media/ipu-bridge.h):
#define MAX_NUM_LINK_FREQS 3
const u8 nr_link_freqs;
const u64 link_freqs[MAX_NUM_LINK_FREQS];
Use the entry from upstream commit 2ee01a0 ("media: ipu-bridge: Add
OV13858 sensor config"), which gives the two frequencies the ov13858
driver supports and was tested there on a Surface Pro 9:
IPU_SENSOR_CONFIG("OVTID858", 2, 540000000, 270000000),
No functional change on the Surface Pro 9, as ov13858 does not read
the link-frequencies property; tested on kernel-surface 7.2.15.
Fixes: 9481aaa ("Add camera support for Surface Pro 9")
Signed-off-by: José María Martín <jmmartinf@hotmail.com>
|
also #174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #170: the
OVTID858entry declares 4 link frequencies butlink_freqs[]holds 3. This uses the entry Sergey Lebedev added upstream in 2ee01a094aba (v7.4-rc1), which Fernando Rimoli tested on an SP9. No functional change; tested on my SP9.