Skip to content

media: ipu-bridge: fix the OVTID858 link frequency count - #191

Open
jmmartinf wants to merge 1 commit into
linux-surface:v7.3-surface-develfrom
jmmartinf:sp9-ov13858-link-freqs
Open

jmmartinf wants to merge 1 commit into
linux-surface:v7.3-surface-develfrom
jmmartinf:sp9-ov13858-link-freqs

Conversation

@jmmartinf

Copy link
Copy Markdown

Follow-up to #170: the OVTID858 entry declares 4 link frequencies but link_freqs[] holds 3. This uses the entry Sergey Lebedev added upstream in 2ee01a094aba (v7.4-rc1), which Fernando Rimoli tested on an SP9. No functional change; tested on my SP9.

The OVTID858 entry declares 4 link frequencies but gives only one:

	IPU_SENSOR_CONFIG("OVTID858", 4, 540000000),

The count does not fit the array it indexes, which holds 3 entries
(include/media/ipu-bridge.h):

	#define MAX_NUM_LINK_FREQS	3
	const u8 nr_link_freqs;
	const u64 link_freqs[MAX_NUM_LINK_FREQS];

Use the entry from upstream commit 2ee01a0 ("media: ipu-bridge: Add
OV13858 sensor config"), which gives the two frequencies the ov13858
driver supports and was tested there on a Surface Pro 9:

	IPU_SENSOR_CONFIG("OVTID858", 2, 540000000, 270000000),

No functional change on the Surface Pro 9, as ov13858 does not read
the link-frequencies property; tested on kernel-surface 7.2.15.

Fixes: 9481aaa ("Add camera support for Surface Pro 9")
Signed-off-by: José María Martín <jmmartinf@hotmail.com>
@zR-JB

zR-JB commented Nov 14, 2026

Copy link
Copy Markdown

also #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants