Skip to content

usb: typec: ucsi: Add Surface UCSI-over-HID driver & charger Artg support - #184

Open
JValdivia23 wants to merge 4 commits into
linux-surface:v7.3-surface-develfrom
JValdivia23:surface-ucsi-hid
Open

JValdivia23 wants to merge 4 commits into
linux-surface:v7.3-surface-develfrom
JValdivia23:surface-ucsi-hid

Conversation

@JValdivia23

Copy link
Copy Markdown

Summary

Several Microsoft Surface models whose Embedded Controller uses the Surface System Aggregator Module (SSAM) — including Surface Book 3 and Surface Pro X — do not expose an ACPI UCSI device (PNP0CA0 / USBC000). Instead, SAM exposes a standard UCSI v1.x Platform Policy Manager (PPM) over HID (HID\VID_045E&UP:FF00_U:F900, handled on Windows by SurfaceUcmUcsiHidClient.sys), leaving /sys/class/typec empty on Linux.

In addition, surface_charger currently only queries SSAM TC=0x02, CID=0x0d (_PSR online status) and does not expose TC=0x02, CID=0x0f (Artg, connected AC / USB-C PD adapter wattage rating in mW).

This series adds both pieces cleanly (checkpatch.pl: 0 errors, 0 warnings across all 4 commits):

  1. HID: Assign HID_GROUP_SURFACE_UCSI to Microsoft Surface UCSI collections (Patchset: surface-ucsi-hid)
    • Assigns HID_GROUP_SURFACE_UCSI (0x0106) in hid_scan_collection() when vendor == USB_VENDOR_ID_MICROSOFT, type == HID_COLLECTION_APPLICATION, and usage is 0xFF00:0xF900.
    • Because sibling SSAM HID functions can share the same VID:PID (e.g. Surface Book 3 Base 045E:09A6 exposes both 0xFF00:0xF900 UCSI PPM and 0xFF0B:0x0101 Base CFU firmware update) and hid-generic yields based solely on id_table without consulting .match(), grouping at scan time (analogous to HID_GROUP_VIVALDI) lets ucsi_surface_hid bind across all Surface models (09A6, 0922, etc.) without disturbing sibling collections.
  2. usb: typec: ucsi: Add Microsoft Surface HID transport driver (Patchset: surface-ucsi-hid)
    • Bridges Feature/Input Report 0x32 (49-byte report: report_id + standard 48-byte UCSI v1.x data block) and Feature Report 0x33 (3-byte PPM capability summary: num_connectors, udc_supported) to the Linux typec_ucsi core (CONFIG_UCSI_SURFACE_HID).
    • Sanitizes uninitialized pre-reset Feature Report 0x32 VERSION bytes (e.g. 0x7628 observed on Surface Book 3 prior to UCSI_PPM_RESET) to UCSI_VERSION_1_1 (0x0110).
    • Defers Input Report 0x32 feature report reads to a workqueue outside the SSAM event notifier callback.
  3. power: supply: surface_charger: Fix positive return value in spwr_ac_get_property() (Patchset: surface-sam)
    • spwr_ac_update_unlocked() returns 1 when state changes; spwr_ac_get_property() previously checked if (status) instead of if (status < 0), returning +1 without populating val->intval on transitions.
  4. power: supply: surface_charger: Expose connected adapter power rating (Patchset: surface-sam)
    • Queries SSAM TC=0x02, CID=0x0f (Artg, rated PSU power in mW) when external power is online (_PSR != 0), gracefully falling back to 0 if unsupported, and exposes POWER_SUPPLY_PROP_INPUT_POWER_LIMIT (in uW, matching macsmc-power).

Closes: linux-surface/surface-pro-x#35
Closes: linux-surface/linux-surface#1069
Related: linux-surface/linux-surface#2195

Hardware Verification (Surface Book 3, Linux 7.3)

  • dmesg on module load (zero warnings/errors):
    ucsi_surface_hid 0019:045E:09A6.0002: hidraw1: HOST HID v1.11 Device [Microsoft Surface 045E:09A6] on 01:15:02:06:00
    ucsi_surface_hid 0019:045E:09A6.0002: Surface UCSI HID PPM (connectors=1, udc_supported=0)
    
  • /sys/class/typec/port0:
    • usb_typec_revision: 1.3, usb_power_delivery_revision: 3.0
    • data_role: host [device], power_role: source [sink], usb_capability: usb2 [usb3], supported_accessory_modes: debug
  • /sys/class/power_supply/ucsi-source-psy-0019:045E:09A6.00021:
    • POWER_SUPPLY_USB_TYPE=[C] PD PD_PPS, POWER_SUPPLY_SCOPE=System
  • Verified live USB-C PD 3.0 negotiation (GET_PDOS + GET_CURRENT_CAM / GET_CONNECTOR_STATUS RDO 20V@3A = 60 W) and SSAM CID=0x0f Artg reporting 60000 mW (60000000 uW) when attached and 0 when unplugged, with all sibling SSAM HID devices (09A6.0004 Base CFU, 09AE keyboard, 09AF touchpad) completely unaffected.

Microsoft Surface devices whose System Aggregator Module (SSAM) exposes
a USB Type-C UCSI Platform Policy Manager over HID advertise a vendor
application collection (Usage Page 0xFF00, Usage 0xF900; matched on
Windows by SurfaceUcmUcsiHidClient.inf via HID\VID_045E&UP:FF00_U:F900).

Because multiple unrelated SSAM HID functions can share the same VID:PID
(for example, Surface Book 3 Base 045E:09A6 exposes both UCSI PPM
collection 0xFF00:0xF900 and CFU firmware update collection 0xFF0B:0x0101),
and hid-generic yields devices based solely on hid_device_id table matches
without consulting .match(), assign HID_GROUP_SURFACE_UCSI during report
descriptor scanning so a dedicated UCSI HID transport driver can bind
cleanly across all Surface models without disturbing sibling collections.

Signed-off-by: Jairo Valdivia <valdiviaprado.ing@gmail.com>
Patchset: surface-ucsi-hid
@qzed

qzed commented Nov 2, 2026

Copy link
Copy Markdown
Member

Thanks for this! I've tested it on the Surface Pro X (details in linux-surface/surface-pro-x#35). Required some fixes/quirks, but then the driver works there as well: ports, partners, PD contracts, PDOs, and connector-change notifications.

Note that the SPX also needed some additional work outside the scope of this PR (registry node, event registry selection in surface_hid, and a driver for the separate USC events that feed the PPM). I'll take care of that separately.

Here are the issues I've found. Would be good if you could address those and check on the SB3:

1. NOT_SUPPORTED without COMMAND_COMPLETE

The SAM PPM answers unsupported commands by setting only UCSI_CCI_NOT_SUPPORTED in the CCI (0x02000000), without UCSI_CCI_COMMAND_COMPLETE. The UCSI core then ignores the notification and runs into a 10 s timeout. As soon as a partner is connected, this happens for GET_CABLE_PROPERTY, which then makes the whole PPM init fail:

SET ctrl=0000000000020011
input report: 32 00 00
GET ... cci=02000000 ctrl=0000000000020011
GET_CABLE_PROPERTY failed (-110)
...
error -ETIMEDOUT: PPM init failed

Fix: in surface_ucsi_hid_fetch_report(), add UCSI_CCI_COMMAND_COMPLETE if UCSI_CCI_NOT_SUPPORTED or UCSI_CCI_ERROR is set without it. With that, GET_CABLE_PROPERTY fails with -EOPNOTSUPP immediately and init completes:

	u32 cci = le32_to_cpu(ush->io_buf->cci);

	if ((cci & (UCSI_CCI_NOT_SUPPORTED | UCSI_CCI_ERROR)) &&
	    !(cci & UCSI_CCI_COMMAND_COMPLETE))
		ush->io_buf->cci |= cpu_to_le32(UCSI_CCI_COMMAND_COMPLETE);

Can you check whether your SB3 also does this? If you didn't see it there, it may be because GET_CABLE_PROPERTY only gets sent once a partner is connected at init time.

2. GET_ALTERNATE_MODES responses have an extra leading byte

The responses start with an extra byte (0x06, presumably the size of one alt-mode entry) before the actual struct ucsi_altmode data:

recipient connector: 06 | 01 ff | 46 1c 00             (CCI length 6)
recipient SOP:       06 | 01 ff | 45 00 1c 40 | 00 ... (CCI length 12)

Without stripping it, the partner's DP alt mode shows up as two bogus entries (svid=0106 vdo=0x1c0045ff and svid=0040) instead of SVID 0xff01 with VDO 0x401c0045 (UFP_D, pin assignments C/D/E). Note that the CCI length for the connector response is one byte short (the last VDO byte is cut off). This needs to be handled in read_message_in() for that command (e.g. by remembering the last command in async_control()). Could you check if the SB3 does this too? I've only seen it with one device so far (a USB-C monitor).

3. VERSION is always garbage

On the SPX, the VERSION field in feature report 0x32 contains random data on every read, also after PPM_RESET, not only before it. The sanitizing in read_version() therefore always kicks in. I'd just drop the check and always report UCSI_VERSION_1_1 (or 1.0), with a comment that the field is not populated, since the report layout fixes the transport to UCSI 1.x anyway. Unless you explicitly see a valid version 1.2 on the SB3.

4. RESET_COMPLETE already set at probe

After boot (on Linux, and also after booting from Windows), CCI often still has RESET_COMPLETE set. The UCSI core then sends SET_NOTIFICATION_ENABLE to clear it, which the PPM never completes, and you get a 10 s delay plus the WARN_ON(cci & UCSI_CCI_RESET_COMPLETE) in ucsi_reset_ppm(). After that, the regular reset and init work fine.

I haven't verified the cause. What I can see is that the core sends this command with an empty mask (ctrl=0000000000000005), while the later SET_NOTIFICATION_ENABLE with mask 0x8001 (ctrl=0000000080010005) completes normally. So the PPM might just ignore a zero mask. If that's the case, setting UCSI_ENABLE_NTFY_CMD_COMPLETE for an empty-mask SET_NOTIFICATION_ENABLE in async_control() would fix it. Not critical, but the WARN splat in the log isn't nice.

5. hid_device_io_stop() in .remove()

The HID core stops IO before calling .remove(), so calling hid_device_io_stop() there logs io already stopped on every unbind. Drop it from surface_ucsi_hid_remove(). The error path in probe is fine.

Minor

  • surface_ucsi_hid_log_caps() reuses io_buf without holding io_lock. That's fine during probe, but it's simpler to use a small local (heap) buffer.
  • The seq field (usage F906) is the same usage as the input report's sequence counter. Always sending 0 works on both devices, so that's fine, but a comment would help.

The surface_charger patches look good to me. The spwr_ac_get_property() return value fix is a real bug fix and could go in independently.

With 1 and 5 fixed (and ideally 2 and 3), I'm happy to merge this.

@qzed

qzed commented Nov 2, 2026

Copy link
Copy Markdown
Member

A small follow-up on the VERSION and seq fields: I've looked at how the Windows driver handles them, using SurfaceUcmUcsiHidClient.sys v2.49.139.0 from the Surface Pro 9 (SQ3) driver package. It's a DMF driver, and the relevant module is Dmf_UcsiHidTransport.

  • Sending (SET_FEATURE report 0x32): it writes CONTROL at offset 9 and MESSAGE_OUT at offset 33, and always writes 0 to the seq/reserved field at offset 3. VERSION isn't touched.
  • Receiving (GET_FEATURE report 0x32): it copies VERSION (offset 1), CCI (offset 5) and MESSAGE_IN (offset 17) into the UCSI data block for UcmUcsiCx. VERSION is passed through unmodified, without any validation.
  • Input report 0x32: it only checks the report ID and then triggers a GET_FEATURE to read the new CCI. The seq value in the input report isn't used.

So the report layout in your driver matches Windows exactly. Always sending seq = 0 is correct. Windows doesn't use the VERSION field either (it's garbage on the SPX), so it's fine to drop the check and always report UCSI_VERSION_1_1.

Neither of the two PPM quirks from my previous comment (NOT_SUPPORTED without COMMAND_COMPLETE, and the extra leading byte in GET_ALTERNATE_MODES responses) is handled in this driver. Either UcmUcsiCx tolerates them or they're also broken on Windows, so they still need to be handled in ucsi_surface_hid on Linux.

Several Microsoft Surface devices (including Surface Book 3 and Surface
Pro X) do not expose an ACPI UCSI device (PNP0CA0 / USBC000). Instead,
their Surface System Aggregator Module (SSAM) exposes a UCSI v1.x
Platform Policy Manager over HID application collection 0xFF00:0xF900
(matched by HID_GROUP_SURFACE_UCSI), using:

- Feature Report 0x32 (49 bytes): standard 48-byte UCSI v1.x data block
  (VERSION, RESERVED/seq, CCI, CONTROL, 16-byte MESSAGE_IN, 16-byte
  MESSAGE_OUT) prefixed by report ID 0x32.
- Input Report 0x32: asynchronous notification signalling a CCI update,
  after which the updated UCSI state is read via Feature Report 0x32.
- Feature Report 0x33 (3 bytes): PPM capability summary (connector count
  and UDC support flag).

Add ucsi_surface_hid to bridge this HID transport to the Linux UCSI core,
exposing /sys/class/typec/port* and ucsi-source-psy-* power_supply
telemetry, with workarounds for SAM UCSI firmware quirks:

- Report UCSI v1.1 unconditionally, as SAM does not populate the version
  field in Feature Report 0x32.
- Synthesize UCSI_CCI_COMMAND_COMPLETE when SAM sets
  UCSI_CCI_NOT_SUPPORTED or UCSI_CCI_ERROR without command completion.
- Strip the leading 1-byte entry length (0x06) prepended by SAM to
  UCSI_GET_ALTERNATE_MODES responses.
- Ensure UCSI_ENABLE_NTFY_CMD_COMPLETE is set on empty-mask
  UCSI_SET_NOTIFICATION_ENABLE commands so SAM clears RESET_COMPLETE.

Tested on Surface Book 3 (0019:045E:09A6) and Surface Pro X
(0019:045E:0922).

Closes: linux-surface/surface-pro-x#35
Signed-off-by: Jairo Valdivia <valdiviaprado.ing@gmail.com>
Patchset: surface-ucsi-hid
…get_property()

spwr_ac_update_unlocked() returns 1 when ac->state changes, 0 when
unchanged, and a negative errno on failure. Checking if (status) in
spwr_ac_get_property() causes the first property read observing a state
transition (such as initial registration when AC is connected) to abort
without populating val->intval and return +1 to power_supply_sysfs.

Check for status < 0 and normalize status to 0 before reading the
requested property.

Fixes: e61ffb3 ("power: supply: Add AC driver for Surface Aggregator Module")
Signed-off-by: Jairo Valdivia <valdiviaprado.ing@gmail.com>
Patchset: surface-sam
SSAM target category SSAM_SSH_TC_BAT command 0x0f (Artg) reports the
rated power of the currently connected AC / USB-C PD adapter in mW when
external power is online (_PSR != 0).

Query CID 0x0f whenever ac->state is non-zero (gracefully falling back to
0 if unsupported by older firmware), emit power_supply_changed() if the
adapter rating changes, and expose the value in microwatts through
POWER_SUPPLY_PROP_INPUT_POWER_LIMIT.

Verified on Surface Book 3 (reports 60000 mW -> 60000000 uW with a 60 W
USB-C PD adapter and 0 when unplugged).

Closes: linux-surface/linux-surface#1069
Signed-off-by: Jairo Valdivia <valdiviaprado.ing@gmail.com>
Patchset: surface-sam
@JValdivia23

Copy link
Copy Markdown
Author

Thanks @qzed for the thorough review and for testing on Surface Pro X!

I have updated the branch (and tested on Surface Book 3 running 7.3.1-1-cachyos) with all of the requested changes in ucsi_surface_hid.c:

  1. Synthesize UCSI_CCI_COMMAND_COMPLETE on NOT_SUPPORTED / ERROR (surface_ucsi_hid_fetch_report()):
    When SAM sets UCSI_CCI_NOT_SUPPORTED or UCSI_CCI_ERROR in CCI without UCSI_CCI_COMMAND_COMPLETE (e.g. UCSI_GET_CABLE_PROPERTY), synthesize UCSI_CCI_COMMAND_COMPLETE in both cci_val and ush->rx_cache.cci so typec_ucsi core fails immediately with -EOPNOTSUPP / -EIO instead of hitting a 10-second timeout.
  2. Strip the leading 0x06 length byte on UCSI_GET_ALTERNATE_MODES (surface_ucsi_hid_read_message_in()):
    Track ush->last_cmd = UCSI_COMMAND(command) in surface_ucsi_hid_async_control(), and when ush->last_cmd == UCSI_GET_ALTERNATE_MODES and ush->rx_cache.message_in[0] == sizeof(struct ucsi_altmode), zero-initialize val and copy from &ush->rx_cache.message_in[1].
  3. Unconditionally report UCSI_VERSION_1_1 (surface_ucsi_hid_read_version()):
    Simplified surface_ucsi_hid_read_version() to unconditionally set *version = UCSI_VERSION_1_1 with a comment documenting that SAM does not populate the version field in Feature Report 0x32.
  4. Work around empty-mask UCSI_SET_NOTIFICATION_ENABLE (surface_ucsi_hid_async_control()):
    When UCSI_COMMAND(command) == UCSI_SET_NOTIFICATION_ENABLE has an empty notification mask (!(command & ~0xffULL)), set command |= UCSI_ENABLE_NTFY_CMD_COMPLETE so SAM processes the command and clears UCSI_CCI_RESET_COMPLETE in ucsi_reset_ppm() (and disables connector/partner notifications in ucsi_unregister()).
  5. Drop redundant hid_device_io_stop(hdev) in surface_ucsi_hid_remove():
    Removed hid_device_io_stop(hdev) from .remove() (keeping it only in probe()'s err_io_stop path).
  6. Minor cleanups:
    Switched surface_ucsi_hid_log_caps() to a dedicated kmemdup() buffer instead of aliasing ush->io_buf, and added a comment noting that seq (usage 0xF906) is always written as 0 by Dmf_UcsiHidTransport.

@qzed

qzed commented Nov 9, 2026

Copy link
Copy Markdown
Member

Just for my understanding regarding 3: Does the SB3 actually return a valid version there or not?

@JValdivia23

Copy link
Copy Markdown
Author

@qzed It does not return a valid version in Report 0x32—it returns 0x7628 (or whatever uninitialized SRAM bytes happen to sit at offset +1..+2 of the KIP firmware's SSAM message buffer).

To be 100% sure why, I disassembled the Surface Book 3 Keyboard Base (KIP) firmware (SurfaceBookBaseV3_KIP_APP1.cfu, version 10.602.139, which hosts the "Surface UCSI" HID device on 01:15:02:06:00) and found the exact firmware bug:

  1. Internally, the KIP firmware initializes ppm->version to 0x0110 (UCSI v1.1):
    In ucsi_ppm_reset (0x000415b8, where r4 = 0x2001f190 is the internal ucsi_ppm_state struct in SRAM), the firmware explicitly writes 0x0110 to ppm->version (offset +0x00):
    415b8: push   {r4, lr}
    415ba: movs   r4, r0
    415bc: movs   r2, #0x70
    415be: movs   r1, #0x0
    415c0: movs   r0, r4
    415c2: bl     0x172b8          @ memset(ppm, 0, 0x70)
    ...
    415d8: mov.w  r0, #0x110
    415dc: strh   r0, [r4, #0x0]   @ ppm->version = 0x0110 (UCSI v1.1)
    415de: pop    {r4, pc}
    
  2. However, GET_FEATURE_REPORT(0x32) forgets to copy ppm->version into the HID report buffer:
    When GET_FEATURE_REPORT for Report ID 0x32 is handled at 0x0003d61c, the firmware builds the 49-byte response in-place inside its 85-byte SSAM queue buffer (r9, where r9[0] == 0x32 and r4 = &r9[1] is the 48-byte UCSI structure):
    3d624: adds.w r1, r9, #0x1     @ r1 = &r9[1] (start of 48-byte UCSI payload)
    3d628: movs   r0, r6           @ r0 = ppm (0x2001f190)
    3d62a: bl     0x42654          @ ucsi_ppm_read(ppm, &r9[1])
    3d62e: movs   r0, #0x0
    3d630: strh.w r0, [r9, #0x3]   @ zeroes RESERVED (UCSI +0x02..0x03)
    3d634: movs   r0, #0x31        @ reply length = 49 bytes
    
    And inside ucsi_ppm_read (0x00042654):
    42670: ldr    r0, [r5, #0x34]  @ r0 = ppm->latched_cci
    42672: str    r0, [r4, #0x4]   @ writes CCI (UCSI +0x04..0x07)
    42674: movs   r2, #0x10
    42676: adds.w r1, r5, #0x40    @ src = &ppm->latched_msg_in
    4267a: adds.w r0, r4, #0x10    @ dst = r4 + 0x10
    4267e: bl     0x15844          @ writes MESSAGE_IN (UCSI +0x10..0x1f)
    
    Neither function ever writes r4 + 0x00 (VERSION, r9[1..2]). Because the incoming GET_FEATURE_REPORT request is only 1 byte (r9[0] = 0x32) and the reply sends 49 bytes from r9 in-place, r9[1..2] simply returns uninitialized SRAM from that queue buffer (28 76 = 0x7628 in my hardware dump):
    32 | 28 76 | 00 00 | 00 00 00 00 | 74 44 0a a8 b4 0e fe 82 | 00..00 | f3 62 49 02 89 97 3c 28 bc 41 ee ee ee ee ee ee
    
    (Notice the 0xee RTOS queue/stack watermark fill bytes at the end of MESSAGE_OUT as well!)

(As a nice bonus, the disassembly also confirmed our other quirks: at 0x00041cc8 unsupported commands execute movs.w r1, #0x2000000 (UCSI_CCI_NOT_SUPPORTED) without setting bit 31 (UCSI_CCI_COMMAND_COMPLETE), and at 0x000419b0 GET_ALTERNATE_MODES reads the TI TPS6598x SMBus block register—including its leading 0x06 byte-count byte—directly into ppm->msg_in.)

Since the KIP firmware actually writes 0x0110 (UCSI_VERSION_1_1) into ppm->version at 0x415d8, would you like me to change the synthesized version in ucsi_surface_hid_read_version() from UCSI_VERSION_1_2 (0x0120) to UCSI_VERSION_1_1 (0x0110) to match what the firmware intended, or keep 0x0120?

@ThicccRacer

Copy link
Copy Markdown

Tested on a second Surface Book 3 (13.5", SAM-over-SSH, Bazzite, kernel 7.3.3), built as an out-of-tree module. It works, and it let me fix a long-standing charging fault. Two things that may be useful for the PR.

1. Product ID differs on this unit

The UCSI collection shows up as 0019:045E:0C0A here, not 045E:09A6:

ucsi_surface_hid 0019:045E:0C0A.0002: hidraw1: <UNKNOWN> HID v1.11 Device [Microsoft Surface 045E:0C0A] on 01:15:02:06:00
ucsi_surface_hid 0019:045E:0C0A.0002: Surface UCSI HID PPM (connectors=1, udc_supported=0)

The sibling interface on 01:15:02:05:00 (usage pages 0xFF05 / 0xFF0B) carries the same ID, as you describe. So matching on the application collection, as the hid-core change does, is the right call; a product ID list would miss units like this one. Result after load: port0, Type-C 1.3, PD 3.0, ucsi-source-psy-* online, and GET_CABLE_PROPERTY failed (-95) once per probe.

2. USB-C charging stops after a clipboard reattach, and a soft CONNECTOR_RESET fixes it

This is the fault reported in linux-surface/linux-surface#623 in 2021 ("USB-C charging is not working anymore after detaching and reattaching. The USB-C cable needs to be removed and plugged in again"). It reproduces every time here with a USB-C charger left in the base.

State after the reattach, with this driver loaded (it re-probes and resets the PPM when the base HID devices come back):

  • typec: port0-partner present, power_role sink, power_operation_mode usb_power_delivery, psy online, 15 V max / 3 A
  • SAM: PSR (tc 0x02, cid 0x0d) returns 0 for both tid 0x01 and tid 0x02
  • both batteries discharging

So the PD contract survives, but the system does not draw from it, and the PPM reset on probe does not change that. Through the UCSI debugfs command file:

Command Result
SET_SINK_PATH, connector 1, enable (0x81001c) rejected
CONNECTOR_RESET, connector 1, soft (0x10003) ADP1 online and both batteries charging within about 7 s

I now send that soft reset from the surface-dtx-daemon attach handler when a partner is present and ADP1 is offline a few seconds after the base returns. Two reattaches so far, charging came back both times without touching the cable (once sent by hand, once by the handler).

I have not tested whether Windows sends the same command; the 2021 reporter said Windows showed the fault too on their unit, and the owner of this one does not recall it there. If it would help, I can capture SAM events (tc 0x02 and 0x11) across a detach and reattach, or test a version of the driver that issues the reset itself.

Side note for anyone reading old logs: the unhandled event (rqid: 0x02, tc: 0x02, tid: 0x02, cid: 0x01, iid: 0x01) line that appears about 5 s after each reattach carries 1f 00 00 00, which looks like the base battery reporting _STA = present. It is unrelated to the charging fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advanced power configuration for USB-C adapter Support for SAM USB-C Events

3 participants