Skip to content

Asr pass refactor - #2795

Merged
Thirumalai-Shaktivel merged 12 commits into
lcompilers:mainfrom
tanay-man:asr-pass-refactor
Aug 16, 2024
Merged

Thirumalai-Shaktivel merged 12 commits into
lcompilers:mainfrom
tanay-man:asr-pass-refactor

Conversation

@tanay-man

@tanay-man tanay-man commented Aug 2, 2024 •

Copy link
Copy Markdown
Contributor

fixes #2777

Comment thread src/libasr/pass/pass_utils.h Resolved
Comment thread src/libasr/pass/pass_utils.h Resolved
tanay-man and others added 3 commits August 14, 2024 20:19
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
Co-authored-by: Thirumalai Shaktivel <74826228+Thirumalai-Shaktivel@users.noreply.github.com>
Comment thread src/libasr/pass/pass_utils.cpp Resolved
Comment thread src/libasr/pass/pass_utils.h Resolved
Comment thread src/libasr/pass/pass_utils.h Resolved
@Thirumalai-Shaktivel

Thirumalai-Shaktivel commented Aug 16, 2024 •

Copy link
Copy Markdown
Collaborator

Remember the following while creating a next PR:

  • After a final review, let's clean up the commits with proper commit message (short description about the changes made in each commits)
  • Proper PR heading which explain what changes were made.

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thirumalai-Shaktivel
Thirumalai-Shaktivel marked this pull request as ready for review August 16, 2024 15:02
@Thirumalai-Shaktivel
Thirumalai-Shaktivel enabled auto-merge (squash) August 16, 2024 15:04
@Thirumalai-Shaktivel
Thirumalai-Shaktivel merged commit 61a27d5 into lcompilers:main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor the StructConstructor

2 participants