Repository navigation
Fix LLVMDictSeparateChaining::dict_deepcopy - #2014
Merged
Merged
Conversation
czgdp1807
marked this pull request as ready for review
June 23, 2023 10:00
certik
approved these changes
Jun 23, 2023
certik
left a comment
certik
left a comment
Contributor
There was a problem hiding this comment.
Perfect. The fix is simple, thanks for doing this @czgdp1807, it would take me forever to figure out.
I have two questions:
- What was the problem?
- Is there any performance regression with this fix?
I am going to merge it, as it fixes the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2011