Repository navigation
ASRVerify: Require signed integer array dimensions - #1903
Merged
Merged
Conversation
Collaborator
Author
|
@certik How do we test this? |
ubaidsk
force-pushed
the
asr_verify_arr_dims
branch
from
June 13, 2023 20:56
bee2fc8 to
a75d763
Compare
certik
approved these changes
Jun 13, 2023
Contributor
Right now just by hand. We should eventually test all of these ASR verify checks systematically, one way to do that is via the MASR tool that @rebcabin is developing. We can setup randomized tests and ensure that if the ASR is outside of the "spec" that verify() always fails, and if it is inside the "spec" that it always succeeds. We'll focus on this after we deliver LFortran/LPython to beta. Right now just best effort solid ASR verify() is all we can do. |
ubaidsk
enabled auto-merge
June 13, 2023 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1899