Repository navigation
Implement sin, cos, tan, sqrt - #184
Merged
Merged
Conversation
certik
enabled auto-merge
February 28, 2022 06:10
Contributor
Author
|
@Smit-create, we can use this approach to implement all other runtime functions. If you want, go ahead and implement the rest of the trig functions. |
Collaborator
|
This looks super good! Thanks. |
Collaborator
|
yeah, I'll add the remaining ones soon. |
Smit-create
approved these changes
Feb 28, 2022
Smit-create
reviewed
Feb 28, 2022
Co-authored-by: Smit Lunagariya <smitlunagariya.mat18@itbhu.ac.in>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This interfaces C implementation from
src/runtime/impure/lfortran_intrinsics.c.