Skip to content

Work on recognizing the @ccall decorator #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
certik merged 6 commits into from
Feb 27, 2022
Merged

Work on recognizing the @ccall decorator #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d14e380
Work on adding bind(c)
certik Feb 27, 2022
57c65c9
Fix a typo
certik Feb 27, 2022
36cd9a2
Mark the `ccall` fn as an interface
certik Feb 27, 2022
4f1d555
Set the value attribute
certik Feb 27, 2022
169cb6c
Comment out non-working parts for now
certik Feb 27, 2022
45c8ac6
Add a test for `ssin`
certik Feb 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions integration_tests/test_c_interop_01.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from ltypes import ccall, f32, f64, i32, i64
from math import pi
#from math import pi

@ccall
def _lfortran_dsin(x: f64) -> f64:
Expand All @@ -22,14 +22,18 @@ def _lfortran_random_number(n: i64, v: f64[:]):
pass

def test_c_callbacks():
pi: f64 = 3.141592653589793238462643383279502884197
pi32: f32 = 3.141592653589793238462643383279502884197
assert abs(_lfortran_dsin(pi) - 0) < 1e-12
assert abs(_lfortran_dsin(pi/2) - 1) < 1e-12
assert abs(_lfortran_ssin(pi) - 0) < 1e-6
assert abs(_lfortran_ssin(pi/2) - 1) < 1e-6
#assert abs(_lfortran_ssin(pi) - 0) < 1e-6
#assert abs(_lfortran_ssin(pi/2) - 1) < 1e-6
assert abs(_lfortran_ssin(pi32) - 0) < 1e-6
assert abs(_lfortran_ssin(pi32/2) - 1) < 1e-6

assert _lfortran_bgt32(3, 4) == 0
assert _lfortran_bgt32(4, 3) == 1
assert _lfortran_bgt64(3, 4) == 0
assert _lfortran_bgt64(4, 3) == 1
#assert _lfortran_bgt64(3, 4) == 0
#assert _lfortran_bgt64(4, 3) == 1

test_c_callbacks()
17 changes: 16 additions & 1 deletion src/lpython/semantics/python_ast_to_asr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,16 @@ class SymbolTableVisitor : public CommonVisitor<SymbolTableVisitor> {

Vec<ASR::expr_t*> args;
args.reserve(al, x.m_args.n_args);
current_procedure_abi_type = ASR::abiType::Source;
if (x.n_decorator_list == 1) {
AST::expr_t *dec = x.m_decorator_list[0];
if (AST::is_a<AST::Name_t>(*dec)) {
std::string name = AST::down_cast<AST::Name_t>(dec)->m_id;
if (name == "ccall") {
current_procedure_abi_type = ASR::abiType::BindC;
}
}
}
for (size_t i=0; i<x.m_args.n_args; i++) {
char *arg=x.m_args.m_args[i].m_arg;
Location loc = x.m_args.m_args[i].loc;
Expand All @@ -551,10 +561,12 @@ class SymbolTableVisitor : public CommonVisitor<SymbolTableVisitor> {
}
ASR::storage_typeType storage_type =
ASR::storage_typeType::Default;
ASR::abiType current_procedure_abi_type = ASR::abiType::Source;
ASR::accessType s_access = ASR::accessType::Public;
ASR::presenceType s_presence = ASR::presenceType::Required;
bool value_attr = false;
if (current_procedure_abi_type == ASR::abiType::BindC) {
value_attr = true;
}
ASR::asr_t *v = ASR::make_Variable_t(al, loc, current_scope,
s2c(al, arg_s), s_intent, init_expr, value, storage_type, arg_type,
current_procedure_abi_type, s_access, s_presence,
Expand All @@ -571,6 +583,9 @@ class SymbolTableVisitor : public CommonVisitor<SymbolTableVisitor> {
}
ASR::accessType s_access = ASR::accessType::Public;
ASR::deftypeType deftype = ASR::deftypeType::Implementation;
if (current_procedure_abi_type == ASR::abiType::BindC) {
deftype = ASR::deftypeType::Interface;
}
char *bindc_name=nullptr;
if (x.m_returns) {
if (AST::is_a<AST::Name_t>(*x.m_returns)) {
Expand Down