Repository navigation
[Bug] [AST->ASR] Result is ok even when there is an error in diagnostics #2810
Description
(lp) ubaid@DESKTOP-TEN39M0:~/projects/lpython$ ./src/bin/lpython
Interactive LPython. Experimental prototype, not ready for end users.
LPython version: 0.22.0-53-g1ef4675ae
* Use Ctrl-D to exit
* Use Enter to submit
* Use Alt-Enter or Ctrl-N to make a new line
- Editing (Keys: Left, Right, Home, End, Backspace, Delete)
- History (Keys: Up, Down)
>>> i: i32 = 5 1,11 ]
>>> from math import sin 1,21 ]
>>> sin(i) 1,7 ]
>>> The above should have printed a semantic error like below:
semantic error: `x` argument of `Sin` must be real or complex
--> input:1:5
|
1 | sin(i)
| ^ But it does not print so. This issue is partially tackled in https://github.com/lcompilers/lpython/pull/2809/files, but I believe it is not the correct fix. We should ideally figure out why result is ok in the following even when there is an error present and rectify it.
if (res.ok) {
r = res.result;
else {
<code to print diagnostics is here>
}PS: I think it is this PR lfortran/lfortran#3380 and the related ones where this issue of diagnostics message not showing up in interactive mode might have crept in.
Activity