Repository navigation
Importing modules does not work inside the function #1317
Description
I came across another issue that doesn't work yet. Like for this example:
import test_import
def test():
print(test_import.print_a())
print(test_import.print_b())
print(test_import.print_c())
test()Error:
lpython integration_tests/test_import_01.py
Internal Compiler Error: Unhandled exception
Traceback (most recent call last):
Binary file "/home/thirumalai/Open_Source/lpython/src/bin/lpython", in _start()
File "./csu/../csu/libc-start.c", line 392, in __libc_start_main_impl()
File "./csu/../sysdeps/nptl/libc_start_call_main.h", line 58, in __libc_start_call_main()
File "/home/thirumalai/Open_Source/lpython/src/bin/lpython.cpp", line 1545, in ??
err = compile_python_to_object_file(arg_file, tmp_o, runtime_library_dir, lpython_pass_manager, compiler_options, time_report);
File "/home/thirumalai/Open_Source/lpython/src/bin/lpython.cpp", line 592, in ??
!(arg_c && compiler_options.disable_main), infile);
AssertFailed: asr_verify(*tu, true, diagnostics)I will try to work on this later this week. After that, I think we are ready to start making python packages.
Originally posted by @Thirumalai-Shaktivel in #1305 (comment)
Reacted by Smit Lunagariya
Activity
certik commentedon Nov 21, 2022
We have two options:
test_import.print_b()just becomes an ExternalSymbol to the correctprint_b()and the information that it was called viatest_import.will be lost.test_importas a symbol into the SymbolTable.The second approach is more general, it would allow to treat modules as symbols / variables. Not sure if we need it or not.
We need this in LFortran too to implement j3-fortran/fortran_proposals#1, so we should do a good design.
@czgdp1807 what is your opinion?
certik commentedon Nov 24, 2022
Regarding priorities, this is nice to have, but not critical, as we can simply import the symbols directly for now.
czgdp1807 commentedon Nov 24, 2022
Oh yes. I am
fixingworking on this exact issue. I think we follow second approach right now. But for the case with function defined inside a module has the same name as the module then second approach will be messier because you will have to do name mangling. Seemathfnfor example,mathfn/sin.pyis a module which hasdef sindefined inside it. So here first approach is an easy to follow option. However where this same name case is not present then second approach is easier.certik commentedon Nov 24, 2022
I would work on this later, I think first we should implement more examples, such as making mathfn much more complex and see what else is missing. Then we can do this one in a more natural manner.
Thirumalai-Shaktivel commentedon Dec 10, 2022
This issue is fixed (#1323), I think.