Skip to content

chore: Declare the diagnostic-events capability in the contract tests - #593

Draft
joker23 wants to merge 1 commit into
mainfrom
devin/1795208960-diagnostic-events-capability
Draft

joker23 wants to merge 1 commit into
mainfrom
devin/1795208960-diagnostic-events-capability

Conversation

@joker23

@joker23 joker23 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Declares diagnostic-events in the sync (service.py) and async (async_service.py) contract test services so the new sdk-test-harness test events/diagnostic events runs. The test was added in v3.2.0-alpha.20 and checks that diagnostic-init is sent to /diagnostic and that no diagnostic payload reaches the analytics route.

  • Both entities already set diagnostic_opt_out = not enableDiagnostics, so the entities need no other change.
Testing

I ran the v3.2.0-alpha.20 harness locally with -run diagnostic against both services, and all 3 diagnostic tests passed on each.

Link to Devin session: https://app.devin.ai/sessions/56b8ade9602745fbba00e59a531bbefa
Open in Devin Desktop: https://app.devin.ai/desktop/session/56b8ade9602745fbba00e59a531bbefa?variant=devin
Requested by: @joker23

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant